Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2021-01-30 Thread Simon Glass
HI Alex, On Wed, 30 Dec 2020 at 19:57, Simon Glass wrote: > > Hi Alex, > > On Tue, 29 Dec 2020 at 17:07, Alex G. wrote: > > > > > > > > On 12/28/20 9:33 PM, Simon Glass wrote: > > > Hi Alex, > > > > > > On Mon, 21 Dec 2020 at 15:24, Alex G. wrote: > > >> > > >> > > >> > > >> On 12/21/20 2:23 PM

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-30 Thread Simon Glass
Hi Alex, On Tue, 29 Dec 2020 at 17:07, Alex G. wrote: > > > > On 12/28/20 9:33 PM, Simon Glass wrote: > > Hi Alex, > > > > On Mon, 21 Dec 2020 at 15:24, Alex G. wrote: > >> > >> > >> > >> On 12/21/20 2:23 PM, Simon Glass wrote: > >>> Hi Alex, > >>> > >>> On Mon, 21 Dec 2020 at 12:28, Alex G. wr

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-30 Thread Tom Rini
On Tue, Dec 29, 2020 at 06:07:08PM -0600, Alex G. wrote: > > > On 12/28/20 9:33 PM, Simon Glass wrote: > > Hi Alex, > > > > On Mon, 21 Dec 2020 at 15:24, Alex G. wrote: > > > > > > > > > > > > On 12/21/20 2:23 PM, Simon Glass wrote: > > > > Hi Alex, > > > > > > > > On Mon, 21 Dec 2020 at 12

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-29 Thread Alex G.
On 12/28/20 9:33 PM, Simon Glass wrote: Hi Alex, On Mon, 21 Dec 2020 at 15:24, Alex G. wrote: On 12/21/20 2:23 PM, Simon Glass wrote: Hi Alex, On Mon, 21 Dec 2020 at 12:28, Alex G. wrote: On 12/18/20 8:28 PM, Simon Glass wrote: Hi Alexandru, On Tue, 15 Dec 2020 at 17:09, Alexandru

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-28 Thread Simon Glass
Hi Alex, On Mon, 21 Dec 2020 at 15:24, Alex G. wrote: > > > > On 12/21/20 2:23 PM, Simon Glass wrote: > > Hi Alex, > > > > On Mon, 21 Dec 2020 at 12:28, Alex G. wrote: > >> > >> On 12/18/20 8:28 PM, Simon Glass wrote: > >>> Hi Alexandru, > >>> > >>> On Tue, 15 Dec 2020 at 17:09, Alexandru Gagniu

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-21 Thread Alex G.
On 12/21/20 2:23 PM, Simon Glass wrote: Hi Alex, On Mon, 21 Dec 2020 at 12:28, Alex G. wrote: On 12/18/20 8:28 PM, Simon Glass wrote: Hi Alexandru, On Tue, 15 Dec 2020 at 17:09, Alexandru Gagniuc wrote: The logical steps in spl_load_simple_fit() are difficult to follow. I think the lo

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-21 Thread Simon Glass
Hi Alex, On Mon, 21 Dec 2020 at 12:28, Alex G. wrote: > > On 12/18/20 8:28 PM, Simon Glass wrote: > > Hi Alexandru, > > > > On Tue, 15 Dec 2020 at 17:09, Alexandru Gagniuc > > wrote: > >> > >> The logical steps in spl_load_simple_fit() are difficult to follow. > >> I think the long comments, if

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-21 Thread Alex G.
On 12/18/20 8:28 PM, Simon Glass wrote: Hi Alexandru, On Tue, 15 Dec 2020 at 17:09, Alexandru Gagniuc wrote: The logical steps in spl_load_simple_fit() are difficult to follow. I think the long comments, ifdefs, and ungodly number of variables seriously affect the readability. In particular,

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-18 Thread Simon Glass
Hi Alexandru, On Tue, 15 Dec 2020 at 17:09, Alexandru Gagniuc wrote: > > The logical steps in spl_load_simple_fit() are difficult to follow. > I think the long comments, ifdefs, and ungodly number of variables > seriously affect the readability. In particular, it violates section 6 > of the codin

[PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-15 Thread Alexandru Gagniuc
The logical steps in spl_load_simple_fit() are difficult to follow. I think the long comments, ifdefs, and ungodly number of variables seriously affect the readability. In particular, it violates section 6 of the coding style, paragraphs (3), and (4). The purpose of this patch is to improve the si