Re: [PATCH 3/3] gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

2020-02-02 Thread Bin Meng
On Fri, Jan 10, 2020 at 3:35 PM Wolfgang Wallner wrote: > > Fix the following in intel_gpio_get_value(): > > * The value of the register is contained in the variable 'reg', not in >'mode'. The variable 'mode' contains only the configuration whether >the gpio is currently an input or an ou

Re: [PATCH 3/3] gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

2020-01-29 Thread Simon Glass
On Fri, 10 Jan 2020 at 00:35, Wolfgang Wallner wrote: > > Fix the following in intel_gpio_get_value(): > > * The value of the register is contained in the variable 'reg', not in >'mode'. The variable 'mode' contains only the configuration whether >the gpio is currently an input or an outp

[PATCH 3/3] gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

2020-01-09 Thread Wolfgang Wallner
Fix the following in intel_gpio_get_value(): * The value of the register is contained in the variable 'reg', not in 'mode'. The variable 'mode' contains only the configuration whether the gpio is currently an input or an output. * The correct bitmasks for the input and output value are