Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-13 Thread Patrick Wildt
On Thu, Jan 13, 2022 at 10:40:21AM -0300, Fabio Estevam wrote: > Hi Patrick, > > On 13/01/2022 10:29, Michael Walle wrote: > > > Why don't you just change it to the correct naming then? > > I agree with Michael: node names should use a dash instead of the > underscore. > > dtc complains about i

Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-13 Thread Fabio Estevam
Hi Patrick, On 13/01/2022 10:29, Michael Walle wrote: Why don't you just change it to the correct naming then? I agree with Michael: node names should use a dash instead of the underscore. dtc complains about it when building with W=2: arch/arm/dts/imx8mm-evk.dtb: Warning (node_name_chars

Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-13 Thread Michael Walle
Am 2022-01-13 14:16, schrieb Patrick Wildt: On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote: Hi, > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > @@ -39,7 +39,7 @@ >filename = "u-boot-spl.bin"; >}; > > - 1d-

Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-13 Thread Patrick Wildt
On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote: > Hi, > > > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > > @@ -39,7 +39,7 @@ > > filename = "u-boot-spl.bin"; > > }; > > > > - 1d-imem { > > + 1

Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-13 Thread Michael Walle
Hi, > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > @@ -39,7 +39,7 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + 1d_imem { I think it is the other way around. Device tree node names should

[PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

2022-01-12 Thread Patrick Wildt
One of the blobs was named using a hyphen instead of an underscore, so make it consistent. Signed-off-by: Patrick Wildt --- arch/arm/dts/imx8mm-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi b/arch/arm/dts/imx8mm-u-boot.dtsi index