Re: [PATCH 3/5] sunxi: move early "SRAM setup" into separate file

2022-01-27 Thread Samuel Holland
On 1/27/22 6:59 PM, Andre Przywara wrote: > On Mon, 24 Jan 2022 20:56:12 -0600 > Samuel Holland wrote: > > Hi Samuel, > >> On 1/24/22 7:15 PM, Andre Przywara wrote: >>> Currently we do some magic "SRAM setup" MMIO writes in s_init(), copied >>> from the original BSP U-Boot. The comment speaks of

Re: [PATCH 3/5] sunxi: move early "SRAM setup" into separate file

2022-01-27 Thread Andre Przywara
On Mon, 24 Jan 2022 20:56:12 -0600 Samuel Holland wrote: Hi Samuel, > On 1/24/22 7:15 PM, Andre Przywara wrote: > > Currently we do some magic "SRAM setup" MMIO writes in s_init(), copied > > from the original BSP U-Boot. The comment speaks of this being required > > before DRAM access gets enab

Re: [PATCH 3/5] sunxi: move early "SRAM setup" into separate file

2022-01-27 Thread Simon Glass
On Mon, 24 Jan 2022 at 18:15, Andre Przywara wrote: > > Currently we do some magic "SRAM setup" MMIO writes in s_init(), copied > from the original BSP U-Boot. The comment speaks of this being required > before DRAM access gets enabled, but there is no indication that this > would actually be requ

Re: [PATCH 3/5] sunxi: move early "SRAM setup" into separate file

2022-01-24 Thread Samuel Holland
On 1/24/22 7:15 PM, Andre Przywara wrote: > Currently we do some magic "SRAM setup" MMIO writes in s_init(), copied > from the original BSP U-Boot. The comment speaks of this being required > before DRAM access gets enabled, but there is no indication that this > would actually be required that ear

[PATCH 3/5] sunxi: move early "SRAM setup" into separate file

2022-01-24 Thread Andre Przywara
Currently we do some magic "SRAM setup" MMIO writes in s_init(), copied from the original BSP U-Boot. The comment speaks of this being required before DRAM access gets enabled, but there is no indication that this would actually be required that early. Move this out of s_init(), into board_init_f(