RE: [PATCH 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function

2021-07-20 Thread Priyanka Jain
; Vladimir Oltean >Subject: [PATCH 3/6] net: dsa: refactor the code to set the port MAC address >into >a dedicated function > >From: Vladimir Oltean > >This snippet of code has a bothering "if (...) return 0" in it which assumes >it is the >last piece of cod

Re: [PATCH 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function

2021-06-29 Thread Ramon Fried
On Tue, Jun 29, 2021 at 8:09 PM Vladimir Oltean wrote: > > From: Vladimir Oltean > > This snippet of code has a bothering "if (...) return 0" in it which > assumes it is the last piece of code running in dsa_port_probe(). > > This makes it difficult to add further code at the end of dsa_port_prob

[PATCH 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function

2021-06-29 Thread Vladimir Oltean
From: Vladimir Oltean This snippet of code has a bothering "if (...) return 0" in it which assumes it is the last piece of code running in dsa_port_probe(). This makes it difficult to add further code at the end of dsa_port_probe() which does not depend on MAC address stuff. So move the code to