Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS

2022-04-19 Thread Tom Rini
On Wed, Apr 20, 2022 at 11:17:21AM +0900, AKASHI Takahiro wrote: > Hi Tom, > > On Tue, Apr 19, 2022 at 08:12:07AM -0400, Tom Rini wrote: > > On Tue, Apr 19, 2022 at 01:11:23PM +0900, AKASHI Takahiro wrote: > > > On Mon, Apr 18, 2022 at 11:09:38PM -0400, Tom Rini wrote: > > > > On Tue, Apr 19, 2022

Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS

2022-04-19 Thread AKASHI Takahiro
Hi Tom, On Tue, Apr 19, 2022 at 08:12:07AM -0400, Tom Rini wrote: > On Tue, Apr 19, 2022 at 01:11:23PM +0900, AKASHI Takahiro wrote: > > On Mon, Apr 18, 2022 at 11:09:38PM -0400, Tom Rini wrote: > > > On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote: > > > > > > > Some defconfig en

Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS

2022-04-19 Thread Tom Rini
On Tue, Apr 19, 2022 at 01:11:23PM +0900, AKASHI Takahiro wrote: > On Mon, Apr 18, 2022 at 11:09:38PM -0400, Tom Rini wrote: > > On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote: > > > > > Some defconfig enables CMD_PART even if none of any partition table > > > types (CONFIG_*_PART

Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS

2022-04-18 Thread AKASHI Takahiro
On Mon, Apr 18, 2022 at 11:09:38PM -0400, Tom Rini wrote: > On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote: > > > Some defconfig enables CMD_PART even if none of any partition table > > types (CONFIG_*_PARTITION) are enabled. > > This will lead to the size growth in SPL/TPL code s

Re: [PATCH 3/7] disk: define nullified functions for !PARTITIONS

2022-04-18 Thread Tom Rini
On Tue, Apr 19, 2022 at 10:01:54AM +0900, AKASHI Takahiro wrote: > Some defconfig enables CMD_PART even if none of any partition table > types (CONFIG_*_PARTITION) are enabled. > This will lead to the size growth in SPL/TPL code since disk/part.c > will be compiled in any way. > We will change dis

[PATCH 3/7] disk: define nullified functions for !PARTITIONS

2022-04-18 Thread AKASHI Takahiro
Some defconfig enables CMD_PART even if none of any partition table types (CONFIG_*_PARTITION) are enabled. This will lead to the size growth in SPL/TPL code since disk/part.c will be compiled in any way. We will change disk/Kconfig later so that CONFIG_PARTITIONS is only enabled when, at least, on