Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: Now that the sunxi_gpio driver handles pull-up/down via the driver model, pin configuration does not need a platform-specific function. Signed-off-by: Samuel Holland I tested on an OrangePi PC (orangepi_pc_defconfig). The 'mmc rescan' command detects

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 19:10:20 +0900 Jaehoon Chung wrote: > Hi Andre, > > On 10/22/21 6:00 PM, Andre Przywara wrote: > > On Fri, 22 Oct 2021 06:58:48 +0900 > > Jaehoon Chung wrote: > > > > Hi Jaehoon, > > > > thanks for having a look! > > > >> Hi, > >> > >> On 10/21/21 1:52 PM, Samuel Hollan

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-22 Thread Jaehoon Chung
Hi Andre, On 10/22/21 6:00 PM, Andre Przywara wrote: > On Fri, 22 Oct 2021 06:58:48 +0900 > Jaehoon Chung wrote: > > Hi Jaehoon, > > thanks for having a look! > >> Hi, >> >> On 10/21/21 1:52 PM, Samuel Holland wrote: >>> Now that the sunxi_gpio driver handles pull-up/down via the driver >>> mo

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 06:58:48 +0900 Jaehoon Chung wrote: Hi Jaehoon, thanks for having a look! > Hi, > > On 10/21/21 1:52 PM, Samuel Holland wrote: > > Now that the sunxi_gpio driver handles pull-up/down via the driver > > model, pin configuration does not need a platform-specific function. > >

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-21 Thread Jaehoon Chung
Hi, On 10/21/21 1:52 PM, Samuel Holland wrote: > Now that the sunxi_gpio driver handles pull-up/down via the driver > model, pin configuration does not need a platform-specific function. > > Signed-off-by: Samuel Holland > --- > > drivers/mmc/sunxi_mmc.c | 8 ++-- > 1 file changed, 2 inser

[PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-20 Thread Samuel Holland
Now that the sunxi_gpio driver handles pull-up/down via the driver model, pin configuration does not need a platform-specific function. Signed-off-by: Samuel Holland --- drivers/mmc/sunxi_mmc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/sunxi_mmc.c b