Re: [PATCH 4/6] usb: xhci-pci: Move reset logic out of XHCI core

2021-02-09 Thread Marek Vasut
On 2/9/21 3:28 AM, Samuel Holland wrote: On 2/8/21 8:27 PM, Samuel Holland wrote: On 2/8/21 5:43 AM, Marek Vasut wrote: On 2/8/21 6:57 AM, Samuel Holland wrote: Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And at least on the All

Re: [PATCH 4/6] usb: xhci-pci: Move reset logic out of XHCI core

2021-02-08 Thread Samuel Holland
On 2/8/21 8:27 PM, Samuel Holland wrote: > On 2/8/21 5:43 AM, Marek Vasut wrote: >> On 2/8/21 6:57 AM, Samuel Holland wrote: >>> Resetting an XHCI controller inside xhci_register undoes any register >>> setup performed by the platform driver. And at least on the Allwinner >>> H6, resetting the XHCI

Re: [PATCH 4/6] usb: xhci-pci: Move reset logic out of XHCI core

2021-02-08 Thread Samuel Holland
On 2/8/21 5:43 AM, Marek Vasut wrote: > On 2/8/21 6:57 AM, Samuel Holland wrote: >> Resetting an XHCI controller inside xhci_register undoes any register >> setup performed by the platform driver. And at least on the Allwinner >> H6, resetting the XHCI controller also resets the PHY, which prevents

Re: [PATCH 4/6] usb: xhci-pci: Move reset logic out of XHCI core

2021-02-08 Thread Andre Przywara
On Mon, 8 Feb 2021 12:43:52 +0100 Marek Vasut wrote: (CC:ing Masahiro, Manni and Kever) > On 2/8/21 6:57 AM, Samuel Holland wrote: > > Resetting an XHCI controller inside xhci_register undoes any register > > setup performed by the platform driver. And at least on the Allwinner > > H6, resetting

Re: [PATCH 4/6] usb: xhci-pci: Move reset logic out of XHCI core

2021-02-08 Thread Marek Vasut
On 2/8/21 6:57 AM, Samuel Holland wrote: Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And at least on the Allwinner H6, resetting the XHCI controller also resets the PHY, which prevents the controller from working. That means the co

[PATCH 4/6] usb: xhci-pci: Move reset logic out of XHCI core

2021-02-07 Thread Samuel Holland
Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And at least on the Allwinner H6, resetting the XHCI controller also resets the PHY, which prevents the controller from working. That means the controller must be taken out of reset before