Re: [PATCH 5/6] drivers: tpm: atmel_twi: implement get_desc operation

2021-11-09 Thread Ilias Apalodimas
Hi Matthew, On Wed, 10 Nov 2021 at 04:43, Mathew McBride wrote: > > > > On Thu, Nov 4, 2021, at 6:39 PM, Ilias Apalodimas wrote: > > Hi Matthew, > > On Thu, 4 Nov 2021 at 03:14, Mathew McBride wrote: > > > static int tpm_atmel_twi_get_desc(struct udevice *dev, char *buf, int size) > > { > > -

Re: [PATCH 5/6] drivers: tpm: atmel_twi: implement get_desc operation

2021-11-09 Thread Mathew McBride
On Thu, Nov 4, 2021, at 6:39 PM, Ilias Apalodimas wrote: > Hi Matthew, > > On Thu, 4 Nov 2021 at 03:14, Mathew McBride wrote: > > > static int tpm_atmel_twi_get_desc(struct udevice *dev, char *buf, int size) > > { > > - return 0; > > + if (size < 50) > > + return -

Re: [PATCH 5/6] drivers: tpm: atmel_twi: implement get_desc operation

2021-11-04 Thread Ilias Apalodimas
Hi Matthew, On Thu, 4 Nov 2021 at 03:14, Mathew McBride wrote: > > Without get_desc, the tpm command will not provide a > description of the device in 'tpm device' or 'tpm info'. > > Due to the characteristics of the Atmel TPM it isn't > possible to determine certain attributes (e.g open/close >

[PATCH 5/6] drivers: tpm: atmel_twi: implement get_desc operation

2021-11-03 Thread Mathew McBride
Without get_desc, the tpm command will not provide a description of the device in 'tpm device' or 'tpm info'. Due to the characteristics of the Atmel TPM it isn't possible to determine certain attributes (e.g open/close status) without using the TPM stack (compare Infineon and ST TPM drivers), so