Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-12 Thread Heinrich Schuchardt
On 12.03.21 05:44, AKASHI Takahiro wrote: > Ilias, > > Sorry, but I will have to repeat my question for better understandings. > > On Sat, Mar 06, 2021 at 12:23:01AM +0200, Ilias Apalodimas wrote: >> The UEFI spec allow a packed array of UEFI device paths in the >> FilePathList[] of an EFI_LOAD_OPT

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Ilias Apalodimas
Akashi-san, [...] > > > > Then you have to deserialize the existing stored device path in > > > > Boot, > > > > append the initrd and serialize it again (and last time I checked this > > > > is not > > > > as easy as it sounds). > > > > > > If we take the format like: > > > kernel path,en

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread AKASHI Takahiro
On Fri, Mar 12, 2021 at 07:37:55AM +0200, Ilias Apalodimas wrote: > Akashi-san, > > On Fri, Mar 12, 2021 at 02:23:13PM +0900, AKASHI Takahiro wrote: > > On Fri, Mar 12, 2021 at 06:55:57AM +0200, Ilias Apalodimas wrote: > > > Akashi-san > > > > > > > > > > > [...] > > > > > +/** > > > > > + * add

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Ilias Apalodimas
Akashi-san, > On Fri, Mar 12, 2021 at 02:23:13PM +0900, AKASHI Takahiro wrote: > On Fri, Mar 12, 2021 at 06:55:57AM +0200, Ilias Apalodimas wrote: > > Akashi-san > > > > > > > > [...] > > > > +/** > > > > + * add_initrd_instance() - Append a device path to load_options > > > > pointing to an >

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread AKASHI Takahiro
On Fri, Mar 12, 2021 at 06:55:57AM +0200, Ilias Apalodimas wrote: > Akashi-san > > > > > [...] > > > +/** > > > + * add_initrd_instance() - Append a device path to load_options pointing > > > to an > > > + * inirtd > > > + if (!initrd_dp) { > > > + printf("Canno

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Ilias Apalodimas
Akashi-san > > [...] > > +/** > > + * add_initrd_instance() - Append a device path to load_options pointing > > to an > > + *inirtd > > + if (!initrd_dp) { > > + printf("Cannot append media vendor device path path\n"); > > + goto out; > > + } > > +

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread AKASHI Takahiro
Ilias, Sorry, but I will have to repeat my question for better understandings. On Sat, Mar 06, 2021 at 12:23:01AM +0200, Ilias Apalodimas wrote: > The UEFI spec allow a packed array of UEFI device paths in the > FilePathList[] of an EFI_LOAD_OPTION. The first file path must > describe the loaded

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Ilias Apalodimas
On Thu, Mar 11, 2021 at 01:38:33PM +0100, Heinrich Schuchardt wrote: > > + } > > + > > + initrd_dp = > > + efi_dp_append_instance((const struct efi_device_path *)&id_dp, > > Please, pass &id_dp.end here to avoid a superfluous end node. Wont this make efi_dp_size() loop endlessly?

Re: [PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-11 Thread Heinrich Schuchardt
On 05.03.21 23:23, Ilias Apalodimas wrote: > The UEFI spec allow a packed array of UEFI device paths in the > FilePathList[] of an EFI_LOAD_OPTION. The first file path must > describe the loaded image but the rest are OS specific. > > Previous patches parse the device path and try to use the second

[PATCH 5/6] efidebug: add multiple device path instances on Boot####

2021-03-05 Thread Ilias Apalodimas
The UEFI spec allow a packed array of UEFI device paths in the FilePathList[] of an EFI_LOAD_OPTION. The first file path must describe the loaded image but the rest are OS specific. Previous patches parse the device path and try to use the second member of the array as an initrd. So let's modify e