Re: [PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional

2020-05-09 Thread David Wu
Hi Stephen, 在 2020/5/1 上午6:45, Stephen Warren 写道: Oh... Judging by your email, you're trying to make this driver work on a Rockchip system. However, you're editing an STM32-specific probe function. You should introduce a new probe function for Rockchip if it needs to work differently to the

Re: [PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional

2020-05-09 Thread David Wu
Hi Patrice, 在 2020/4/30 下午10:00, Patrice CHOTARD 写道: @@ -647,8 +653,10 @@ static void eqos_stop_clks_stm32(struct udevice *dev) debug("%s(dev=%p):\n", __func__, dev); - clk_disable(>clk_tx); - clk_disable(>clk_rx); + if (clk_valid(>clk_tx)) +

Re: [PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional

2020-04-30 Thread Stephen Warren
On 4/30/20 4:43 AM, David Wu wrote: > For others using, clk_rx and clk_tx may not be necessary, > and their clock names are different. > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c > @@ -1691,20 +1699,16 @@ static int eqos_probe_resources_stm32(struct udevice > *dev) >

Re: [PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional

2020-04-30 Thread Patrice CHOTARD
Hi David On 4/30/20 12:43 PM, David Wu wrote: > For others using, clk_rx and clk_tx may not be necessary, > and their clock names are different. > > Signed-off-by: David Wu > --- > > drivers/net/dwc_eth_qos.c | 65 +++ > 1 file changed, 31 insertions(+), 34

[PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional

2020-04-30 Thread David Wu
For others using, clk_rx and clk_tx may not be necessary, and their clock names are different. Signed-off-by: David Wu --- drivers/net/dwc_eth_qos.c | 65 +++ 1 file changed, 31 insertions(+), 34 deletions(-) diff --git a/drivers/net/dwc_eth_qos.c