Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-15 Thread Simon Glass
Hi Akashi, On Mon, 15 Jun 2020 at 18:34, AKASHI Takahiro wrote: > > On Mon, Jun 15, 2020 at 10:34:56AM -0400, Tom Rini wrote: > > On Sun, Jun 14, 2020 at 09:58:48PM -0600, Simon Glass wrote: > > > Hi Akashi, > > > > > > On Sun, 14 Jun 2020 at 20:59, AKASHI Takahiro > > > wrote: > > > > > > > > O

Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-15 Thread Tom Rini
On Tue, Jun 16, 2020 at 09:34:30AM +0900, AKASHI Takahiro wrote: > On Mon, Jun 15, 2020 at 10:34:56AM -0400, Tom Rini wrote: > > On Sun, Jun 14, 2020 at 09:58:48PM -0600, Simon Glass wrote: > > > Hi Akashi, > > > > > > On Sun, 14 Jun 2020 at 20:59, AKASHI Takahiro > > > wrote: > > > > > > > > On

Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-15 Thread AKASHI Takahiro
On Mon, Jun 15, 2020 at 10:34:56AM -0400, Tom Rini wrote: > On Sun, Jun 14, 2020 at 09:58:48PM -0600, Simon Glass wrote: > > Hi Akashi, > > > > On Sun, 14 Jun 2020 at 20:59, AKASHI Takahiro > > wrote: > > > > > > On Thu, Jun 04, 2020 at 07:39:35PM -0400, Tom Rini wrote: > > > > On Fri, May 22, 20

Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-15 Thread Tom Rini
On Sun, Jun 14, 2020 at 09:58:48PM -0600, Simon Glass wrote: > Hi Akashi, > > On Sun, 14 Jun 2020 at 20:59, AKASHI Takahiro > wrote: > > > > On Thu, Jun 04, 2020 at 07:39:35PM -0400, Tom Rini wrote: > > > On Fri, May 22, 2020 at 04:32:40PM -0600, Simon Glass wrote: > > > > > > > There is a lot of

Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-14 Thread Simon Glass
Hi Akashi, On Sun, 14 Jun 2020 at 20:59, AKASHI Takahiro wrote: > > On Thu, Jun 04, 2020 at 07:39:35PM -0400, Tom Rini wrote: > > On Fri, May 22, 2020 at 04:32:40PM -0600, Simon Glass wrote: > > > > > There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, > > > suggest using the co

Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-14 Thread AKASHI Takahiro
On Thu, Jun 04, 2020 at 07:39:35PM -0400, Tom Rini wrote: > On Fri, May 22, 2020 at 04:32:40PM -0600, Simon Glass wrote: > > > There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, > > suggest using the compile-time construct. > > > > Signed-off-by: Simon Glass > > Applied to u-

Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-04 Thread Tom Rini
On Fri, May 22, 2020 at 04:32:40PM -0600, Simon Glass wrote: > There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, > suggest using the compile-time construct. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-05-22 Thread Simon Glass
There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, suggest using the compile-time construct. Signed-off-by: Simon Glass --- scripts/checkpatch.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 22869992e90..33ec4e2