Re: [PATCH 8/8] net: gmac_rockchip: Add dwc_eth_qos support

2020-05-09 Thread David Wu
Hi Stephen, 在 2020/5/1 上午6:52, Stephen Warren 写道: I'm really confused; with a filename like gmac_rockchip.c that sounds like it's driver for a MAC device. DWC EQoS is also a MAC device. The two shouldn't be related or coupled in any way. I think what you need is to completely drop this patch

Re: [PATCH 8/8] net: gmac_rockchip: Add dwc_eth_qos support

2020-04-30 Thread Stephen Warren
On 4/30/20 4:45 AM, David Wu wrote: > Change the original data structure so that Rockchip's Soc > gmac controller can support the designware.c and dwc_eth_qos.c > drivers, a Soc can only support one. I'm really confused; with a filename like gmac_rockchip.c that sounds like it's driver for a MAC

[PATCH 8/8] net: gmac_rockchip: Add dwc_eth_qos support

2020-04-30 Thread David Wu
Change the original data structure so that Rockchip's Soc gmac controller can support the designware.c and dwc_eth_qos.c drivers, a Soc can only support one. Signed-off-by: David Wu --- drivers/net/Kconfig | 2 +- drivers/net/gmac_rockchip.c | 160 ++--