Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-19 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Tue, 19 Dec 2023 19:16:37 +0100: > On 19.12.2023 19:13, Greg Kroah-Hartman wrote: > > On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote: > >> From: Rafał Miłecki > >> > >> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less >

Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-19 Thread Rafał Miłecki
On 19.12.2023 19:13, Greg Kroah-Hartman wrote: On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote: From: Rafał Miłecki 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less mtd dependent 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells Shouldn't th

Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-19 Thread Greg Kroah-Hartman
On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less >mtd dependent > 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells Shouldn't this be 2 different patches? thanks, greg

[PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-19 Thread Rafał Miłecki
From: Rafał Miłecki 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less mtd dependent 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells Signed-off-by: Rafał Miłecki Reviewed-by: Miquel Raynal --- V2: Don't introduce memleak when handling nvmem_device_read() fai