Re: [PATCH V3 3/3] net: phy: Make phy_interface_is_rgmii a switch statement

2023-05-06 Thread Tom Rini
On Fri, Apr 14, 2023 at 05:06:45PM -0500, Nishanth Menon wrote: > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This exposed a problem > in range checking functions to identify the interface type. Though > this specific api wa

Re: [PATCH V3 3/3] net: phy: Make phy_interface_is_rgmii a switch statement

2023-04-30 Thread Ramon Fried
On Sat, Apr 15, 2023 at 1:06 AM Nishanth Menon wrote: > > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This exposed a problem > in range checking functions to identify the interface type. Though > this specific api wasn't imp

[PATCH V3 3/3] net: phy: Make phy_interface_is_rgmii a switch statement

2023-04-14 Thread Nishanth Menon
Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes with Linux") reordered the enum definitions. This exposed a problem in range checking functions to identify the interface type. Though this specific api wasn't impacted (all the RGMII definitions remained within range), this exp