Re: [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay

2023-08-23 Thread Nishanth Menon
On 06:38-20230823, Nishanth Menon wrote: > On 15:48-20230823, Nitin Yadav wrote: > [...] > > > > > > -    for (i = MMC_HS; i <= MMC_HS_400; i++) { > > > > > +    for (i = MMC_LEGACY; i <= MMC_HS_400; i++) { > > > > > > > > I'm not super familiar with mmc drivers in general, but it feels like > >

Re: [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay

2023-08-23 Thread Nishanth Menon
On 15:48-20230823, Nitin Yadav wrote: [...] > > > > -    for (i = MMC_HS; i <= MMC_HS_400; i++) { > > > > +    for (i = MMC_LEGACY; i <= MMC_HS_400; i++) { > > > > > > I'm not super familiar with mmc drivers in general, but it feels like > > > this bit does not really belong in this patch. > > >

Re: [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay

2023-08-23 Thread Nitin Yadav
On 23/08/23 15:45, Nitin Yadav wrote: Hi Mattijs, On 23/08/23 13:36, Mattijs Korpershoek wrote: On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: From: Nitin Yadav U-Boot is fail to boot class U1 UHS SD cards (such as microcenter) due to incorrect OTAP and ITAP delay select values.

Re: [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay

2023-08-23 Thread Nitin Yadav
Hi Mattijs, On 23/08/23 13:36, Mattijs Korpershoek wrote: On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: From: Nitin Yadav U-Boot is fail to boot class U1 UHS SD cards (such as microcenter) due to incorrect OTAP and ITAP delay select values. Update OTAP and ITAP delay select values

Re: [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay

2023-08-23 Thread Mattijs Korpershoek
On mar., août 22, 2023 at 13:41, Nishanth Menon wrote: > From: Nitin Yadav > > U-Boot is fail to boot class U1 UHS SD cards (such as microcenter) > due to incorrect OTAP and ITAP delay select values. Update OTAP and > ITAP delay select values based on recommeded RIOT values to fix boot > issue.

[PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay

2023-08-22 Thread Nishanth Menon
From: Nitin Yadav U-Boot is fail to boot class U1 UHS SD cards (such as microcenter) due to incorrect OTAP and ITAP delay select values. Update OTAP and ITAP delay select values based on recommeded RIOT values to fix boot issue. Signed-off-by: Nitin Yadav Signed-off-by: Nishanth Menon --- Pick