Re: [PATCH v1] i2c: nuvoton: Add NPCM7xx i2c driver

2022-05-23 Thread Jim Liu
Hi Heiko Thanks for your reply. and i have some explanation about command check. in the npcm_i2c_xfer, it can support 1 or 2 nmsgs so need for function . the test as below: --- U-Boot>i2c probe 0x50 Valid chip addresses:nmsgs= 1 50 U-Boot>i2c md 50 11.2 4 nmsgs= 2 0011: 1

Re: [PATCH v1] i2c: nuvoton: Add NPCM7xx i2c driver

2022-05-23 Thread Heiko Schocher
Hello Jim, On 23.05.22 10:16, Jim Liu wrote: > Hi Heiko > > Thanks for your reply. > I will follow your suggestion to modify it for version 2. > and some explain and question as below: > > 1. while function will do the i2c recovery feature . > the function will break when toggle 27 times or S

Re: [PATCH v1] i2c: nuvoton: Add NPCM7xx i2c driver

2022-05-23 Thread Jim Liu
Hi Heiko Thanks for your reply. I will follow your suggestion to modify it for version 2. and some explain and question as below: 1. while function will do the i2c recovery feature . the function will break when toggle 27 times or SDA is high. > + while (1) { > + /* toggle SCL

Re: [PATCH v1] i2c: nuvoton: Add NPCM7xx i2c driver

2022-05-18 Thread Heiko Schocher
Hello Jim, On 17.05.22 10:25, Jim Liu wrote: > Add Nuvoton BMC NPCM750 i2c driver > > Signed-off-by: Jim Liu > --- > drivers/i2c/Kconfig| 5 + > drivers/i2c/Makefile | 1 + > drivers/i2c/npcm-i2c.c | 632 + > 3 files changed, 638 insertions(+) >

[PATCH v1] i2c: nuvoton: Add NPCM7xx i2c driver

2022-05-17 Thread Jim Liu
Add Nuvoton BMC NPCM750 i2c driver Signed-off-by: Jim Liu --- drivers/i2c/Kconfig| 5 + drivers/i2c/Makefile | 1 + drivers/i2c/npcm-i2c.c | 632 + 3 files changed, 638 insertions(+) create mode 100644 drivers/i2c/npcm-i2c.c diff --git a/driver