Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Ramon Fried
On Thu, Feb 25, 2021 at 9:33 PM Simon Glass wrote: > > On Thu, 25 Feb 2021 at 10:55, Fabio Estevam wrote: > > > > On Thu, Feb 25, 2021 at 4:58 AM Michael Walle wrote: > > > > > This is how it looks in the linux tree: > > > > > > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l > > > 633 > > >

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Simon Glass
On Thu, 25 Feb 2021 at 10:55, Fabio Estevam wrote: > > On Thu, Feb 25, 2021 at 4:58 AM Michael Walle wrote: > > > This is how it looks in the linux tree: > > > > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l > > 633 > > Yes, 'ethernet' is the recommended node name as per the Devicetree > Sp

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Fabio Estevam
On Thu, Feb 25, 2021 at 4:58 AM Michael Walle wrote: > This is how it looks in the linux tree: > > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l > 633 Yes, 'ethernet' is the recommended node name as per the Devicetree Specification doc item "2.2.2 Generic Names Recommendation".

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Tom Rini
On Thu, Feb 25, 2021 at 08:57:37AM +0100, Michael Walle wrote: > Hi Simon, > > Am 2021-02-25 03:31, schrieb Simon Glass: > > On Wed, 24 Feb 2021 at 17:51, Michael Walle wrote: > > > Am 2021-02-24 22:34, schrieb Vladimir Oltean: > > > > On Wed, Feb 24, 2021 at 08:26:14PM +0100, Michael Walle wrote

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Michael Walle
Hi Simon, Am 2021-02-25 03:31, schrieb Simon Glass: On Wed, 24 Feb 2021 at 17:51, Michael Walle wrote: Am 2021-02-24 22:34, schrieb Vladimir Oltean: > On Wed, Feb 24, 2021 at 08:26:14PM +0100, Michael Walle wrote: >> > Wasn't the intention of David's patch, in fact, to have the new uclass >> >

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Simon Glass
Hi Michael, On Wed, 24 Feb 2021 at 17:51, Michael Walle wrote: > > Am 2021-02-24 22:34, schrieb Vladimir Oltean: > > On Wed, Feb 24, 2021 at 08:26:14PM +0100, Michael Walle wrote: > >> > Wasn't the intention of David's patch, in fact, to have the new uclass > >> > name also match on "eth" aliases

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Michael Walle
Am 2021-02-24 22:34, schrieb Vladimir Oltean: On Wed, Feb 24, 2021 at 08:26:14PM +0100, Michael Walle wrote: > Wasn't the intention of David's patch, in fact, to have the new uclass > name also match on "eth" aliases? If I'm correct, doesn't this mean > we'll have to replace the strcmp with an a

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Vladimir Oltean
On Wed, Feb 24, 2021 at 08:26:14PM +0100, Michael Walle wrote: > > Wasn't the intention of David's patch, in fact, to have the new uclass > > name also match on "eth" aliases? If I'm correct, doesn't this mean > > we'll have to replace the strcmp with an actual stem check? > > I guess it was intend

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Michael Walle
Am 2021-02-24 19:14, schrieb Vladimir Oltean: On Wed, Feb 24, 2021 at 06:21:33PM +0100, Michael Walle wrote: Am 2021-01-19 21:40, schrieb Tom Rini: > On Tue, Jan 19, 2021 at 03:01:38PM -0500, Tom Rini wrote: > > On Fri, Jan 08, 2021 at 10:53:05AM +0800, David Wu wrote: > > > > > dev_read_alias_s

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Vladimir Oltean
On Wed, Feb 24, 2021 at 08:14:17PM +0200, Vladimir Oltean wrote: > strcmp returns -101 > matches returns 0 Damn, I posted the wrong output. Of course the program returns: strcmp returns -101 matches returns 1 reverse matches returns 0

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Vladimir Oltean
On Wed, Feb 24, 2021 at 06:21:33PM +0100, Michael Walle wrote: > Am 2021-01-19 21:40, schrieb Tom Rini: > > On Tue, Jan 19, 2021 at 03:01:38PM -0500, Tom Rini wrote: > > > On Fri, Jan 08, 2021 at 10:53:05AM +0800, David Wu wrote: > > > > > > > dev_read_alias_seq() used uc_drv->name compared to ali

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Michael Walle
[resend, sorry forgot to put Vladimir in CC] Am 2021-01-19 21:40, schrieb Tom Rini: On Tue, Jan 19, 2021 at 03:01:38PM -0500, Tom Rini wrote: On Fri, Jan 08, 2021 at 10:53:05AM +0800, David Wu wrote: > dev_read_alias_seq() used uc_drv->name compared to alias > stem string, Ethernet's alias ste

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-24 Thread Michael Walle
Am 2021-01-19 21:40, schrieb Tom Rini: On Tue, Jan 19, 2021 at 03:01:38PM -0500, Tom Rini wrote: On Fri, Jan 08, 2021 at 10:53:05AM +0800, David Wu wrote: > dev_read_alias_seq() used uc_drv->name compared to alias > stem string, Ethernet's alias stem uses "ethernet", which > does not match the

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-01-19 Thread Tom Rini
On Tue, Jan 19, 2021 at 03:01:38PM -0500, Tom Rini wrote: > On Fri, Jan 08, 2021 at 10:53:05AM +0800, David Wu wrote: > > > dev_read_alias_seq() used uc_drv->name compared to alias > > stem string, Ethernet's alias stem uses "ethernet", which > > does not match the eth-uclass driver name "eth", ca

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-01-19 Thread Tom Rini
On Fri, Jan 08, 2021 at 10:53:05AM +0800, David Wu wrote: > dev_read_alias_seq() used uc_drv->name compared to alias > stem string, Ethernet's alias stem uses "ethernet", which > does not match the eth-uclass driver name "eth", can not > get the correct index of ethernet alias namer. So it seems >

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-01-08 Thread Simon Glass
On Thu, 7 Jan 2021 at 19:53, David Wu wrote: > > dev_read_alias_seq() used uc_drv->name compared to alias > stem string, Ethernet's alias stem uses "ethernet", which > does not match the eth-uclass driver name "eth", can not > get the correct index of ethernet alias namer. So it seems > change ucl

[PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-01-07 Thread David Wu
dev_read_alias_seq() used uc_drv->name compared to alias stem string, Ethernet's alias stem uses "ethernet", which does not match the eth-uclass driver name "eth", can not get the correct index of ethernet alias namer. So it seems change uclass driver name to match the alias stem is a more reasonab