Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-20 Thread Johan Jonker
On 3/20/23 02:32, Kever Yang wrote: > Hi Johan, > > On 2023/3/19 19:34, Johan Jonker wrote: >> >> On 3/18/23 21:20, Simon Glass wrote: >>> Hi Johan, >>> >>> On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: The current divider to calculate the bank ID can change. Use a constant

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-19 Thread Kever Yang
Hi Johan, On 2023/3/19 19:34, Johan Jonker wrote: On 3/18/23 21:20, Simon Glass wrote: Hi Johan, On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: The current divider to calculate the bank ID can change. Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider. What is the motivation for

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-19 Thread Jonas Karlman
On 2023-03-19 14:51, Jonas Karlman wrote: > On 2023-03-19 13:55, Johan Jonker wrote: >> >> >> On 3/19/23 13:20, Jonas Karlman wrote: >>> Hi Johan, >>> On 2023-03-19 12:34, Johan Jonker wrote: On 3/18/23 21:20, Simon Glass wrote: > Hi Johan, > > On Thu, 16 Mar 2023 at

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-19 Thread Jonas Karlman
On 2023-03-19 13:55, Johan Jonker wrote: > > > On 3/19/23 13:20, Jonas Karlman wrote: >> Hi Johan, >> On 2023-03-19 12:34, Johan Jonker wrote: >>> >>> >>> On 3/18/23 21:20, Simon Glass wrote: Hi Johan, On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: > > The current

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-19 Thread Johan Jonker
On 3/19/23 13:20, Jonas Karlman wrote: > Hi Johan, > On 2023-03-19 12:34, Johan Jonker wrote: >> >> >> On 3/18/23 21:20, Simon Glass wrote: >>> Hi Johan, >>> >>> On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: The current divider to calculate the bank ID can change. Use a

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-19 Thread Jonas Karlman
Hi Johan, On 2023-03-19 12:34, Johan Jonker wrote: > > > On 3/18/23 21:20, Simon Glass wrote: >> Hi Johan, >> >> On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: >>> >>> The current divider to calculate the bank ID can change. >>> Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider. >> >

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-19 Thread Johan Jonker
On 3/18/23 21:20, Simon Glass wrote: > Hi Johan, > > On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: >> >> The current divider to calculate the bank ID can change. >> Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider. > > What is the motivation for this patch? The gpio-ranges

Re: [PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-18 Thread Simon Glass
Hi Johan, On Thu, 16 Mar 2023 at 10:46, Johan Jonker wrote: > > The current divider to calculate the bank ID can change. > Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider. What is the motivation for this patch? > > Signed-off-by: Johan Jonker > --- > drivers/gpio/rk_gpio.c | 2 +- >

[PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

2023-03-16 Thread Johan Jonker
The current divider to calculate the bank ID can change. Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider. Signed-off-by: Johan Jonker --- drivers/gpio/rk_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c index