Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Stanley Chu
On Fri, Mar 11, 2022 at 10:53 AM Giulio Benetti wrote: > > Hi Stanley, > > > Il giorno 11 mar 2022, alle ore 03:13, Stanley Chu > > ha scritto: > > > > Hi Tom, > > We need time to prepare linux dts, can I send the rest of the drivers > > first or need to wait until the linux dts is submitted?

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Giulio Benetti
Hi Stanley, > Il giorno 11 mar 2022, alle ore 03:13, Stanley Chu > ha scritto: > > Hi Tom, > We need time to prepare linux dts, can I send the rest of the drivers > first or need to wait until the linux dts is submitted? > Because I want to remove some unused nodes/properties away from linux

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Tom Rini
On Fri, Mar 11, 2022 at 10:13:19AM +0800, Stanley Chu wrote: > Hi Tom, > We need time to prepare linux dts, can I send the rest of the drivers > first or need to wait until the linux dts is submitted? > Because I want to remove some unused nodes/properties away from linux > dts to reduce dtb

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Stanley Chu
Hi Tom, We need time to prepare linux dts, can I send the rest of the drivers first or need to wait until the linux dts is submitted? Because I want to remove some unused nodes/properties away from linux dts to reduce dtb size, can we use different dts for uboot? Thanks a lot for your comments.

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Giulio Benetti
On 11/03/22 02:06, Giulio Benetti wrote: Hi Stanley, On 11/03/22 01:50, Stanley Chu wrote: Hi Giulio, Thank you for your comment, I've submitted a clk driver patch to address this. https://patchwork.ozlabs.org/project/uboot/patch/20220225075954.3965-1-ys...@nuvoton.com/ Good to see that!

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Giulio Benetti
Hi Stanley, On 11/03/22 01:50, Stanley Chu wrote: Hi Giulio, Thank you for your comment, I've submitted a clk driver patch to address this. https://patchwork.ozlabs.org/project/uboot/patch/20220225075954.3965-1-ys...@nuvoton.com/ Good to see that! But I think you should submit the entire

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Stanley Chu
Hi Jesse, Thanks for the comment, this will be addressed in the next patches. -- Stanley On Thu, Dec 16, 2021 at 6:16 AM Jesse Taube wrote: > > > > On 12/15/21 13:32, Sean Anderson wrote: > > On 12/14/21 9:57 PM, Stanley Chu wrote: > >> Add basic support for the Nuvoton NPCM845 BMC. > >> > >>

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Stanley Chu
Hi Sean, Thank you for your comment, I've submitted a clk driver patch to address this. https://patchwork.ozlabs.org/project/uboot/patch/20220225075954.3965-1-ys...@nuvoton.com/ As for the reset controller, I will take reset-syscon driver for that. -- Stanley On Thu, Dec 16, 2021 at 2:32 AM

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Stanley Chu
Hi Giulio, Thank you for your comment, I've submitted a clk driver patch to address this. https://patchwork.ozlabs.org/project/uboot/patch/20220225075954.3965-1-ys...@nuvoton.com/ -- Stanley On Wed, Dec 15, 2021 at 8:12 PM Giulio Benetti wrote: > > Hi Stanley, > > On 15/12/21 03:57, Stanley

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Stanley Chu
Hi Sean, Thanks for the review. It is addressed in the gpio driver patch as below. https://patchwork.ozlabs.org/project/uboot/patch/20220225021450.18690-1-ys...@nuvoton.com/ -- Stanley On Thu, Dec 16, 2021 at 6:30 AM Sean Anderson wrote: > > On 12/15/21 5:16 PM, Jesse Taube wrote: > > > > > >

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-03-10 Thread Tom Rini
On Wed, Dec 15, 2021 at 10:57:52AM +0800, Stanley Chu wrote: > Add basic support for the Nuvoton NPCM845 BMC. > > Signed-off-by: Stanley Chu I see there's a number of outstanding questions to this first part of the port. Can you please address them? Furthermore, the defconfig and dts patches

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2021-12-15 Thread Sean Anderson
On 12/14/21 9:57 PM, Stanley Chu wrote: Add basic support for the Nuvoton NPCM845 BMC. Signed-off-by: Stanley Chu --- arch/arm/Kconfig | 9 + arch/arm/Makefile | 1 + arch/arm/include/asm/arch-npcm8xx/clock.h | 164

Re: [PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2021-12-15 Thread Giulio Benetti
Hi Stanley, On 15/12/21 03:57, Stanley Chu wrote: Add basic support for the Nuvoton NPCM845 BMC. Signed-off-by: Stanley Chu --- arch/arm/Kconfig | 9 + arch/arm/Makefile | 1 + arch/arm/include/asm/arch-npcm8xx/clock.h | 164

[PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2021-12-14 Thread Stanley Chu
Add basic support for the Nuvoton NPCM845 BMC. Signed-off-by: Stanley Chu --- arch/arm/Kconfig | 9 + arch/arm/Makefile | 1 + arch/arm/include/asm/arch-npcm8xx/clock.h | 164 arch/arm/include/asm/arch-npcm8xx/espi.h | 23 ++