Re: [PATCH v1 2/2] i2c: microchip: fix erroneous late ack send

2022-11-14 Thread Heiko Schocher
Hello Conor, On 26.10.22 09:49, Conor Dooley wrote: > A late ack is currently being sent at the end of a transfer due to > incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert Ack > bit is being written to the controller's control reg after the last > byte has been received, causing

Re: [PATCH v1 2/2] i2c: microchip: fix erroneous late ack send

2022-11-13 Thread Heiko Schocher
Hello Conor, On 26.10.22 09:49, Conor Dooley wrote: > A late ack is currently being sent at the end of a transfer due to > incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert Ack > bit is being written to the controller's control reg after the last > byte has been received, causing

Re: [PATCH v1 2/2] i2c: microchip: fix erroneous late ack send

2022-10-27 Thread Padmarao.Begari
Hi Conor, > On Wed, 2022-10-26 at 07:54 +, Conor Dooley - M52691 wrote: > On 26/10/2022 08:49, Conor Dooley wrote: > > A late ack is currently being sent at the end of a transfer due to > > incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert > > Ack > > bit is being written to the

Re: [PATCH v1 2/2] i2c: microchip: fix erroneous late ack send

2022-10-27 Thread Padmarao.Begari
> On Wed, 2022-10-26 at 08:49 +0100, Conor Dooley wrote: > A late ack is currently being sent at the end of a transfer due to > incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert Ack > bit is being written to the controller's control reg after the last > byte has been received,

Re: [PATCH v1 2/2] i2c: microchip: fix erroneous late ack send

2022-10-26 Thread Conor.Dooley
On 26/10/2022 08:49, Conor Dooley wrote: > A late ack is currently being sent at the end of a transfer due to > incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert Ack > bit is being written to the controller's control reg after the last > byte has been received, causing it to sent

[PATCH v1 2/2] i2c: microchip: fix erroneous late ack send

2022-10-26 Thread Conor Dooley
A late ack is currently being sent at the end of a transfer due to incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert Ack bit is being written to the controller's control reg after the last byte has been received, causing it to sent another byte with the ack. Instead, the AA flag