Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-08 Thread Simon Glass
Hi Andy, On Mon, 8 Nov 2021 at 01:38, Andy Shevchenko wrote: > > On Sun, Nov 7, 2021 at 6:43 PM Simon Glass wrote: > > On Sat, 6 Nov 2021 at 01:59, Andy Shevchenko > > wrote: > > > On Saturday, November 6, 2021, Simon Glass wrote: > > >> On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko > > >> wr

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-08 Thread Andy Shevchenko
On Sun, Nov 7, 2021 at 6:43 PM Simon Glass wrote: > On Sat, 6 Nov 2021 at 01:59, Andy Shevchenko > wrote: > > On Saturday, November 6, 2021, Simon Glass wrote: > >> On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko > >> wrote: > >> > > >> > Compiler is not happy: > >> > > >> > common/image-board.c:

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-07 Thread Simon Glass
Hi Andy, On Sat, 6 Nov 2021 at 01:59, Andy Shevchenko wrote: > > > > On Saturday, November 6, 2021, Simon Glass wrote: >> >> Hi Andy, >> >> On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko >> wrote: >> > >> > Compiler is not happy: >> > >> > common/image-board.c: In function ‘boot_get_kbd’: >> > co

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-06 Thread Andy Shevchenko
On Saturday, November 6, 2021, Simon Glass wrote: > Hi Andy, > > On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko > wrote: > > > > Compiler is not happy: > > > > common/image-board.c: In function ‘boot_get_kbd’: > > common/image-board.c:902:17: warning: implicit declaration of function > ‘do_bdinfo’

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-05 Thread Simon Glass
Hi Andy, On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko wrote: > > Compiler is not happy: > > common/image-board.c: In function ‘boot_get_kbd’: > common/image-board.c:902:17: warning: implicit declaration of function > ‘do_bdinfo’ [-Wimplicit-function-declaration] > 902 | do_bdin

[PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-05 Thread Andy Shevchenko
Compiler is not happy: common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: warning: implicit declaration of function ‘do_bdinfo’ [-Wimplicit-function-declaration] 902 | do_bdinfo(NULL, 0, 0, NULL); | ^ Move the forward de