Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-02 Thread Lukasz Majewski
Hi Vladimir, > Hi Lukasz, > > On Thu, Jun 01, 2023 at 01:44:30PM +0200, Marek Vasut wrote: > > I think after two years, it would be good to drop the RB tags and > > do another round of reviews. > > To expand on Marek's point. > > In those past 2 years, Tim Harvey has put in a considerable

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Vladimir Oltean
Hi Lukasz, On Thu, Jun 01, 2023 at 01:44:30PM +0200, Marek Vasut wrote: > I think after two years, it would be good to drop the RB tags and do another > round of reviews. To expand on Marek's point. In those past 2 years, Tim Harvey has put in a considerable amount of effort to add another

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Marek Vasut
On 6/1/23 13:02, Lukasz Majewski wrote: Hi Marek, On 6/1/23 12:00, Lukasz Majewski wrote: After this change PHY ports are able to pass packets between them (and also to CPU port). The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the PHY ports of the switch and generate

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Lukasz Majewski
Hi Marek, > On 6/1/23 12:00, Lukasz Majewski wrote: > > After this change PHY ports are able to pass packets between them > > (and also to CPU port). > > > > The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get > > the PHY ports of the switch and generate proper mask. > > > >

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Marek Vasut
On 6/1/23 12:00, Lukasz Majewski wrote: After this change PHY ports are able to pass packets between them (and also to CPU port). The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the PHY ports of the switch and generate proper mask. Signed-off-by: Lukasz Majewski

[PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2023-06-01 Thread Lukasz Majewski
After this change PHY ports are able to pass packets between them (and also to CPU port). The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the PHY ports of the switch and generate proper mask. Signed-off-by: Lukasz Majewski Reviewed-by: Ramon Fried ---

Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2021-05-08 Thread Ramon Fried
On Wed, Mar 17, 2021 at 4:14 PM Lukasz Majewski wrote: > > After this change PHY ports are able to pass packets between them (and > also to CPU port). > > The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the > PHY ports of the switch and generate proper mask. > > Signed-off-by:

[PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them

2021-03-17 Thread Lukasz Majewski
After this change PHY ports are able to pass packets between them (and also to CPU port). The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get the PHY ports of the switch and generate proper mask. Signed-off-by: Lukasz Majewski --- drivers/net/phy/mv88e61xx.c | 9 +++-- 1