[PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v10: - move unnecessary code from bnxt_read_rom_hwaddr to bnxt_eth_probe Changes in v9: - remove bnxt_ver

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Marek Behún
Hello Roman, some last requests from me. On Mon, 8 Nov 2021 14:46:10 -0800 Roman Bacik wrote: > +#define bnxt_down_chip(bp) bnxt_hwrm_run(down_chip, bp, 0) > +#define bnxt_bring_chip(bp)bnxt_hwrm_run(bring_chip, bp, 1) Could these be changed to functions instead of macros, please? >

RE: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
Hi Marek, > -Original Message- > From: Marek Behún > Sent: Monday, November 8, 2021 3:43 PM > To: Roman Bacik > Cc: U-Boot Mailing List ; Pali Rohar > ; Bharat Gooty ; Joe > Hershberger ; Ramon Fried > > Subject: Re: [PATCH v10 1/2] net: brcm: netXtreme drive

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Marek Behún
On Mon, 8 Nov 2021 16:48:33 -0800 Roman Bacik wrote: > To be honest changing status codes coming from FW does not seem right. But > we will try to make the requested changes. I looked at kernel's implementation of this driver and these hwrm functions and they don't return STATUS_*. Marek

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Roman Bacik
On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wrote: > > On Mon, 8 Nov 2021 16:48:33 -0800 > Roman Bacik wrote: > > > To be honest changing status codes coming from FW does not seem right. But > > we will try to make the requested changes. > > I looked at kernel's implementation of this driver and t

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-08 Thread Marek Behún
On Mon, 8 Nov 2021 18:20:43 -0800 Roman Bacik wrote: > On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wrote: > > > > On Mon, 8 Nov 2021 16:48:33 -0800 > > Roman Bacik wrote: > > > > > To be honest changing status codes coming from FW does not seem right. But > > > we will try to make the requeste

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-09 Thread Ramon Fried
On Tue, Nov 9, 2021 at 4:55 AM Marek Behún wrote: > > On Mon, 8 Nov 2021 18:20:43 -0800 > Roman Bacik wrote: > > > On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wrote: > > > > > > On Mon, 8 Nov 2021 16:48:33 -0800 > > > Roman Bacik wrote: > > > > > > > To be honest changing status codes coming fro

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-09 Thread Roman Bacik
On Tue, Nov 9, 2021 at 12:37 AM Ramon Fried wrote: > > On Tue, Nov 9, 2021 at 4:55 AM Marek Behún wrote: > > > > On Mon, 8 Nov 2021 18:20:43 -0800 > > Roman Bacik wrote: > > > > > On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wrote: > > > > > > > > On Mon, 8 Nov 2021 16:48:33 -0800 > > > > Roman B

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-12-01 Thread Ramon Fried
On Tue, Nov 9, 2021 at 5:24 PM Roman Bacik wrote: > > On Tue, Nov 9, 2021 at 12:37 AM Ramon Fried wrote: > > > > On Tue, Nov 9, 2021 at 4:55 AM Marek Behún wrote: > > > > > > On Mon, 8 Nov 2021 18:20:43 -0800 > > > Roman Bacik wrote: > > > > > > > On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wro