Re: [PATCH v2] boot: add support for button commands

2024-02-13 Thread Tom Rini
On Tue, Jan 09, 2024 at 11:51:09AM +, Caleb Connolly wrote: > With the relatively new button API in U-Boot, it's now much easier to > model the common usecase of mapping arbitrary actions to different > buttons during boot - for example entering fastboot mode, setting some > additional kernel

Re: [PATCH v2] boot: add support for button commands

2024-01-18 Thread Dragan Simic
On 2024-01-18 16:11, Michael Walle wrote: Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it

Re: [PATCH v2] boot: add support for button commands

2024-01-18 Thread Michael Walle
Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it should work in any case. Even if the user

Re: [PATCH v2] boot: add support for button commands

2024-01-18 Thread Dragan Simic
On 2024-01-18 08:59, Michael Walle wrote: Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it

Re: [PATCH v2] boot: add support for button commands

2024-01-17 Thread Michael Walle
Hi, Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it should work in any case. Even if the

Re: [PATCH v2] boot: add support for button commands

2024-01-17 Thread Dragan Simic
Hello Caleb and Michael, On 2024-01-11 10:38, Michael Walle wrote: This is simply awesome, but I see one possible issue -- the need to have proper environment variables defined for a particular board or device, to make the buttons work as expected.  Obviously, those environment variables can b

Re: [PATCH v2] boot: add support for button commands

2024-01-11 Thread Michael Walle
>> This is simply awesome, but I see one possible issue -- the need to have >> proper environment variables defined for a particular board or device, >> to make the buttons work as expected.  Obviously, those environment >> variables can be absent or can become missing for numerous reasons. > > Is

Re: [PATCH v2] boot: add support for button commands

2024-01-10 Thread Caleb Connolly
On 10/01/2024 18:08, Dragan Simic wrote: > On 2024-01-09 12:51, Caleb Connolly wrote: >> With the relatively new button API in U-Boot, it's now much easier to >> model the common usecase of mapping arbitrary actions to different >> buttons during boot - for example entering fastboot mode, settin

Re: [PATCH v2] boot: add support for button commands

2024-01-10 Thread Dragan Simic
On 2024-01-09 12:51, Caleb Connolly wrote: With the relatively new button API in U-Boot, it's now much easier to model the common usecase of mapping arbitrary actions to different buttons during boot - for example entering fastboot mode, setting some additional kernel cmdline arguments, or bootin

[PATCH v2] boot: add support for button commands

2024-01-09 Thread Caleb Connolly
With the relatively new button API in U-Boot, it's now much easier to model the common usecase of mapping arbitrary actions to different buttons during boot - for example entering fastboot mode, setting some additional kernel cmdline arguments, or booting with a custom recovery ramdisk, to name a f