Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-12-15 Thread Sean Anderson
On Sun, 14 Feb 2021 03:17:18 +0100, Giulio Benetti wrote: > Improve clk_get_rate() @return documentation that otherwise is a bit > ambiguous. At the moment I expect to return 0 as error since the return > type is 'ulong', instead the function really returns negative value in > case the

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-11-23 Thread Sean Anderson
On 2/13/21 9:17 PM, Giulio Benetti wrote: Improve clk_get_rate() @return documentation that otherwise is a bit ambiguous. At the moment I expect to return 0 as error since the return type is 'ulong', instead the function really returns negative value in case the corresponding function pointer is

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-04-04 Thread Giulio Benetti
Hi Lukasz, kindly ping Best regards -- Giulio Benetti Benetti Engineering sas On 2/23/21 1:25 AM, Giulio Benetti wrote: On 2/22/21 8:13 PM, Heinrich Schuchardt wrote: On 2/14/21 4:49 AM, Jesse T wrote: Awesome, thanks! I must have forgotten how twos complement works for a sec... On Sat,

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-22 Thread Giulio Benetti
On 2/22/21 8:13 PM, Heinrich Schuchardt wrote: On 2/14/21 4:49 AM, Jesse T wrote: Awesome, thanks! I must have forgotten how twos complement works for a sec... On Sat, Feb 13, 2021 at 10:17 PM Giulio Benetti < giulio.bene...@benettiengineering.com> wrote: Hi Jesse, Il giorno 14 feb 2021,

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-22 Thread Heinrich Schuchardt
On 2/14/21 4:49 AM, Jesse T wrote: Awesome, thanks! I must have forgotten how twos complement works for a sec... On Sat, Feb 13, 2021 at 10:17 PM Giulio Benetti < giulio.bene...@benettiengineering.com> wrote: Hi Jesse, Il giorno 14 feb 2021, alle ore 03:58, Jesse T ha scritto:  This looks

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Jesse T
Awesome, thanks! I must have forgotten how twos complement works for a sec... On Sat, Feb 13, 2021 at 10:17 PM Giulio Benetti < giulio.bene...@benettiengineering.com> wrote: > Hi Jesse, > > Il giorno 14 feb 2021, alle ore 03:58, Jesse T > ha scritto: > >  > This looks good to me, and helps

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Giulio Benetti
Hi Jesse, > Il giorno 14 feb 2021, alle ore 03:58, Jesse T ha > scritto: > >  > This looks good to me, and helps beginners like me. As for the function > itself, i have 2 concerns: If it does return a negative value why is it > unsigned, if it is in fact signed that a clock above 2.2Ghz is

Re: [PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Jesse T
This looks good to me, and helps beginners like me. As for the function itself, i have 2 concerns: If it does return a negative value why is it unsigned, if it is in fact signed that a clock above 2.2Ghz is a negative number. As for the IS_ERR_VALUE macro there still is a chance that it will error

[PATCH v2] clk: fix clk_get_rate() documentation

2021-02-13 Thread Giulio Benetti
Improve clk_get_rate() @return documentation that otherwise is a bit ambiguous. At the moment I expect to return 0 as error since the return type is 'ulong', instead the function really returns negative value in case the corresponding function pointer is null and returns 0 if the clock is invalid.