Re: [PATCH v2] cmd: Ensure sf operates on spi flash

2020-02-04 Thread Sean Anderson
On 2/4/20 5:49 AM, Bin Meng wrote: > Hi Sean, > > On Mon, Jan 20, 2020 at 7:13 AM Sean Anderson wrote: >> >> Currently, the sf command will probe anything attached to an spi bus, >> regardless >> of whether it is UCLASS_SPI_FLASH. This came up when testing the mmc_spi >> driver, > > Did you

Re: [PATCH v2] cmd: Ensure sf operates on spi flash

2020-02-04 Thread Bin Meng
Hi Sean, On Mon, Jan 20, 2020 at 7:13 AM Sean Anderson wrote: > > Currently, the sf command will probe anything attached to an spi bus, > regardless > of whether it is UCLASS_SPI_FLASH. This came up when testing the mmc_spi > driver, Did you do something like: => sf probe 1 0 ? > which is

[PATCH v2] cmd: Ensure sf operates on spi flash

2020-01-19 Thread Sean Anderson
Currently, the sf command will probe anything attached to an spi bus, regardless of whether it is UCLASS_SPI_FLASH. This came up when testing the mmc_spi driver, which is accessed via spi but is UCLASS_MMC. If the uclass is not what sf expects, then the "flash" variable will not actually have type