Re: [PATCH v2] lib: sparse: allocate FASTBOOT_MAX_BLK_WRITE instead of small number

2023-07-25 Thread Tom Rini
On Fri, Jul 07, 2023 at 10:13:34AM +0200, Mattijs Korpershoek wrote: > Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") > fixed cache alignment for systems with a D-CACHE. > > However it introduced some performance regressions [1] on system > flashing huge images, such as A

Re: [PATCH v2] lib: sparse: allocate FASTBOOT_MAX_BLK_WRITE instead of small number

2023-07-07 Thread Mattijs Korpershoek
Hi Qianfan, Thank you for your review. On ven., juil. 07, 2023 at 18:54, qianfan wrote: > 在 2023/7/7 16:13, Mattijs Korpershoek 写道: >> Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") >> fixed cache alignment for systems with a D-CACHE. >> >> However it introduced some pe

Re: [PATCH v2] lib: sparse: allocate FASTBOOT_MAX_BLK_WRITE instead of small number

2023-07-07 Thread qianfan
在 2023/7/7 16:13, Mattijs Korpershoek 写道: Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") fixed cache alignment for systems with a D-CACHE. However it introduced some performance regressions [1] on system flashing huge images, such as Android. On AM62x SK EVM, we also

[PATCH v2] lib: sparse: allocate FASTBOOT_MAX_BLK_WRITE instead of small number

2023-07-07 Thread Mattijs Korpershoek
Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") fixed cache alignment for systems with a D-CACHE. However it introduced some performance regressions [1] on system flashing huge images, such as Android. On AM62x SK EVM, we also observe such performance penalty: Sending spar