Re: [PATCH v2] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

Hi Johan, On Wed, 5 Jan 2022 at 09:40, Johan Jonker wrote: > > Hi Simon, > > Thanks you for your comments. > Shown below are the objdump results of the full U-boot binary > dw_apb_timer_of_to_plat() function. > Same goes for the dw_apb_timer_probe() function. > With if (IS_ENABLED(OF_REAL)) I don

Re: [PATCH v2] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

Hi, In addition of the previous message, when I compile with the opposite of OF_REAL (= !OF_PLATDATA) it generates an error in SPL. Like to know why OF_REAL doesn't work. For these couple of extra lines to increase build coverage inside does it matter a lot by adding another messy set of #if

Re: [PATCH v2] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

Hi Simon, Thanks you for your comments. Shown below are the objdump results of the full U-boot binary dw_apb_timer_of_to_plat() function. Same goes for the dw_apb_timer_probe() function. With if (IS_ENABLED(OF_REAL)) I don't get a useful timer result (boot hangs after timer probe, because in full

Re: [PATCH v2] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

Hi Johan, On Tue, 4 Jan 2022 at 19:15, Johan Jonker wrote: > > The Rockchip rk3066 SoC has 3 dw-apb-timer nodes. > U-boot is compiled with OF_PLATDATA TPL/SPL options, > so add OF_PLATDATA support for the dw-apb-timer. > Also change driver name to be able to compile with > U-boot scripts. No rese

[PATCH v2] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

The Rockchip rk3066 SoC has 3 dw-apb-timer nodes. U-boot is compiled with OF_PLATDATA TPL/SPL options, so add OF_PLATDATA support for the dw-apb-timer. Also change driver name to be able to compile with U-boot scripts. No reset OF_PLATDATA support was added, because the rk3066 nodes don't need/have