Re: [PATCH v2 04/20] rockchip: pine64: pinebook-pro: migrate to rockchip_early_misc_init_r

2024-02-12 Thread Dragan Simic
Hello Peter, On 2024-02-12 14:41, Peter Robinson wrote: On Fri, 9 Feb 2024 at 09:50, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding

Re: [PATCH v2 04/20] rockchip: pine64: pinebook-pro: migrate to rockchip_early_misc_init_r

2024-02-12 Thread Quentin Schulz
Hi Peter, On 2/12/24 14:41, Peter Robinson wrote: On Fri, 9 Feb 2024 at 09:50, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding

Re: [PATCH v2 04/20] rockchip: pine64: pinebook-pro: migrate to rockchip_early_misc_init_r

2024-02-12 Thread Peter Robinson
On Fri, 9 Feb 2024 at 09:50, Quentin Schulz wrote: > > From: Quentin Schulz > > Compared to the original misc_init_r from Rockchip mach code, > setup_iodomain() is added and rockchip_setup_macaddr() is not called. > > It is assumed adding rockchip_setup_macaddr() back is fine. > Let's use

Re: [PATCH v2 04/20] rockchip: pine64: pinebook-pro: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Dragan Simic
On 2024-02-09 10:50, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r

[PATCH v2 04/20] rockchip: pine64: pinebook-pro: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r instead of reimplementing the whole