Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-12 Thread Dragan Simic
On 2024-02-12 15:21, Peter Robinson wrote: On Mon, 12 Feb 2024 at 14:16, Dragan Simic wrote: On 2024-02-12 14:56, Peter Robinson wrote: > On Fri, 9 Feb 2024 at 18:57, Dragan Simic wrote: >> On 2024-02-09 19:36, Mark Kettenis wrote: >> >> Date: Fri, 09 Feb 2024 18:58:01 +0100 >> >> From:

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-12 Thread Peter Robinson
On Mon, 12 Feb 2024 at 14:16, Dragan Simic wrote: > > Hello Peter, > > On 2024-02-12 14:56, Peter Robinson wrote: > > On Fri, 9 Feb 2024 at 18:57, Dragan Simic wrote: > >> On 2024-02-09 19:36, Mark Kettenis wrote: > >> >> Date: Fri, 09 Feb 2024 18:58:01 +0100 > >> >> From: Dragan Simic > >> >>

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-12 Thread Dragan Simic
Hello Peter, On 2024-02-12 14:56, Peter Robinson wrote: On Fri, 9 Feb 2024 at 18:57, Dragan Simic wrote: On 2024-02-09 19:36, Mark Kettenis wrote: >> Date: Fri, 09 Feb 2024 18:58:01 +0100 >> From: Dragan Simic >> Please, see my comments below. >> >> On 2024-02-09 10:50, Quentin Schulz wrote:

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-12 Thread Peter Robinson
On Fri, 9 Feb 2024 at 18:57, Dragan Simic wrote: > > Hello Mark, > > On 2024-02-09 19:36, Mark Kettenis wrote: > >> Date: Fri, 09 Feb 2024 18:58:01 +0100 > >> From: Dragan Simic > >> Please, see my comments below. > >> > >> On 2024-02-09 10:50, Quentin Schulz wrote: > >> > From: Quentin Schulz

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Dragan Simic
Hello Mark, On 2024-02-09 19:36, Mark Kettenis wrote: Date: Fri, 09 Feb 2024 18:58:01 +0100 From: Dragan Simic Please, see my comments below. On 2024-02-09 10:50, Quentin Schulz wrote: > From: Quentin Schulz > > The functions aren't used anywhere else than in board.c, therefore, > let's not

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Mark Kettenis
> Date: Fri, 09 Feb 2024 18:58:01 +0100 > From: Dragan Simic > > Hello Quentin, > > Please, see my comments below. > > On 2024-02-09 10:50, Quentin Schulz wrote: > > From: Quentin Schulz > > > > The functions aren't used anywhere else than in board.c, therefore, > > let's not expose them

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Dragan Simic
Hello Quentin, Please, see my comments below. On 2024-02-09 10:50, Quentin Schulz wrote: From: Quentin Schulz The functions aren't used anywhere else than in board.c, therefore, let's not expose them anymore at all. This merges misc.c and board.c together and removes the functions from the

[PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz The functions aren't used anywhere else than in board.c, therefore, let's not expose them anymore at all. This merges misc.c and board.c together and removes the functions from the misc.h header file. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by: Quentin