Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-30 Thread mchitale
On Mon, 2023-07-24 at 22:18 +0200, Heinrich Schuchardt wrote: > MMC, SATA, and USB may be using PCI based controllers. > Initialize the PCI sub-system before trying to boot. > > Remove the initialization for NVMe that is now redundant. > > Signed-off-by: Heinrich Schuchardt > > --- > v2: >

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-25 Thread Simon Glass
Hi Tom, On Tue, 25 Jul 2023 at 15:39, Tom Rini wrote: > > On Tue, Jul 25, 2023 at 03:28:37PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 25 Jul 2023 at 10:37, Tom Rini wrote: > > > > > > On Tue, Jul 25, 2023 at 08:51:55AM -0600, Simon Glass wrote: > > > > On Mon, 24 Jul 2023 at 14:19,

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-25 Thread Tom Rini
On Tue, Jul 25, 2023 at 03:28:37PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 25 Jul 2023 at 10:37, Tom Rini wrote: > > > > On Tue, Jul 25, 2023 at 08:51:55AM -0600, Simon Glass wrote: > > > On Mon, 24 Jul 2023 at 14:19, Heinrich Schuchardt > > > wrote: > > > > > > > > MMC, SATA, and USB ma

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-25 Thread Simon Glass
Hi Tom, On Tue, 25 Jul 2023 at 10:37, Tom Rini wrote: > > On Tue, Jul 25, 2023 at 08:51:55AM -0600, Simon Glass wrote: > > On Mon, 24 Jul 2023 at 14:19, Heinrich Schuchardt > > wrote: > > > > > > MMC, SATA, and USB may be using PCI based controllers. > > > Initialize the PCI sub-system before tr

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-25 Thread Tom Rini
On Tue, Jul 25, 2023 at 08:51:55AM -0600, Simon Glass wrote: > On Mon, 24 Jul 2023 at 14:19, Heinrich Schuchardt > wrote: > > > > MMC, SATA, and USB may be using PCI based controllers. > > Initialize the PCI sub-system before trying to boot. > > > > Remove the initialization for NVMe that is now r

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-25 Thread Heinrich Schuchardt
On 25.07.23 16:51, Simon Glass wrote: On Mon, 24 Jul 2023 at 14:19, Heinrich Schuchardt wrote: MMC, SATA, and USB may be using PCI based controllers. Initialize the PCI sub-system before trying to boot. Remove the initialization for NVMe that is now redundant. Signed-off-by: Heinrich Schucha

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-25 Thread Simon Glass
On Mon, 24 Jul 2023 at 14:19, Heinrich Schuchardt wrote: > > MMC, SATA, and USB may be using PCI based controllers. > Initialize the PCI sub-system before trying to boot. > > Remove the initialization for NVMe that is now redundant. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > Cen

Re: [PATCH v2 1/1] spl: initialize PCI before booting

2023-07-24 Thread Tom Rini
On Mon, Jul 24, 2023 at 10:18:41PM +0200, Heinrich Schuchardt wrote: > MMC, SATA, and USB may be using PCI based controllers. > Initialize the PCI sub-system before trying to boot. > > Remove the initialization for NVMe that is now redundant. > > Signed-off-by: Heinrich Schuchardt Reviewed-by:

[PATCH v2 1/1] spl: initialize PCI before booting

2023-07-24 Thread Heinrich Schuchardt
MMC, SATA, and USB may be using PCI based controllers. Initialize the PCI sub-system before trying to boot. Remove the initialization for NVMe that is now redundant. Signed-off-by: Heinrich Schuchardt --- v2: Centralize the PCI initialization --- common/spl/spl.c | 7 +++ commo

Re: [PATCH v2 1/1] spl: initialize PCI before booting from MMC

2023-07-24 Thread Tom Rini
On Mon, Jul 24, 2023 at 07:50:02PM +0200, Heinrich Schuchardt wrote: > On 24.07.23 17:12, Tom Rini wrote: > > On Mon, Jul 24, 2023 at 12:33:08PM +0200, Heinrich Schuchardt wrote: > > > Some MMC controllers are PCI bus devices. Before calling spl_mmc_load() we > > > must bind the PCI devices. > > >

Re: [PATCH v2 1/1] spl: initialize PCI before booting from MMC

2023-07-24 Thread Heinrich Schuchardt
On 24.07.23 17:12, Tom Rini wrote: On Mon, Jul 24, 2023 at 12:33:08PM +0200, Heinrich Schuchardt wrote: Some MMC controllers are PCI bus devices. Before calling spl_mmc_load() we must bind the PCI devices. Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese --- v2: Remove emp

Re: [PATCH v2 1/1] spl: initialize PCI before booting from MMC

2023-07-24 Thread Tom Rini
On Mon, Jul 24, 2023 at 12:33:08PM +0200, Heinrich Schuchardt wrote: > Some MMC controllers are PCI bus devices. Before calling spl_mmc_load() we > must bind the PCI devices. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Stefan Roese > --- > v2: > Remove empty line at start of code

[PATCH v2 1/1] spl: initialize PCI before booting from MMC

2023-07-24 Thread Heinrich Schuchardt
Some MMC controllers are PCI bus devices. Before calling spl_mmc_load() we must bind the PCI devices. Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese --- v2: Remove empty line at start of code block. Add empty line before return. --- common/spl/spl_mmc.c | 4 1