Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-30 Thread Mario Kicherer
On 2023-01-27 18:58, Tom Rini wrote: Okay, I think I understand your point now. I am not sure what's the best way to proceed here. Should I try to build all targets that contain BOOT_DEVICE_NOR and add a #define for BOOT_DEVICE_NOR2 if my patch really breaks the build? Or should I just add a

Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-27 Thread Tom Rini
On Fri, Jan 27, 2023 at 06:55:46PM +0100, Mario Kicherer wrote: > On 2023-01-27 18:10, Tom Rini wrote: > > Yes, all of the platforms that define the value (since it roughly means > > "ROM set this value in something we can check") instead of enum'ing it > > still compile that file and now fail to

Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-27 Thread Mario Kicherer
On 2023-01-27 18:10, Tom Rini wrote: Yes, all of the platforms that define the value (since it roughly means "ROM set this value in something we can check") instead of enum'ing it still compile that file and now fail to build. Okay, I think I understand your point now. I am not sure what's the

Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-27 Thread Tom Rini
On Fri, Jan 27, 2023 at 05:56:48PM +0100, Mario Kicherer wrote: > Hello Tom, > > On 2023-01-26 20:17, Tom Rini wrote: > > This breaks a lot of platforms, as it only covers a few of the cases > > where BOOT_DEVICE_NOR is listed. I would also really like to see how > > this ends up being used in

Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-27 Thread Mario Kicherer
Hello Tom, On 2023-01-26 20:17, Tom Rini wrote: This breaks a lot of platforms, as it only covers a few of the cases where BOOT_DEVICE_NOR is listed. I would also really like to see how this ends up being used in the board specific case as I do wonder if we can't solve this some other way that

Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-26 Thread Tom Rini
On Thu, Jan 19, 2023 at 04:28:21PM +0100, Mario Kicherer wrote: > Add BOOT_DEVICE_NOR2 as a second SPL_LOAD_IMAGE_METHOD to enable a > board-specific spl_nor_get_uboot_base() function to return an alternative > address in the NOR flash in case booting from BOOT_DEVICE_NOR fails. > >

[PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-19 Thread Mario Kicherer
Add BOOT_DEVICE_NOR2 as a second SPL_LOAD_IMAGE_METHOD to enable a board-specific spl_nor_get_uboot_base() function to return an alternative address in the NOR flash in case booting from BOOT_DEVICE_NOR fails. Signed-off-by: Mario Kicherer --- arch/arm/include/asm/spl.h | 1 +