Re: [PATCH v2 1/5] sunxi: psci: clean away preprocessor macros

2023-09-27 Thread Sam Edwards
On 9/27/23 10:34, Andre Przywara wrote: In the majority of cases, there are no changes to the text section introduced by this patch. In the R40 case, there's a small change where the compiler adds a NULL check onto the result of the `(void *)cpucfg + SUN8I_R40_PWR_CLAMP(cpu)` computation, which w

Re: [PATCH v2 1/5] sunxi: psci: clean away preprocessor macros

2023-09-27 Thread Andre Przywara
On Fri, 18 Aug 2023 14:17:07 -0700 Sam Edwards wrote: > On 8/18/23 10:40, Sam Edwards wrote: > > On 8/18/23 07:11, Andre Przywara wrote: > > > > Hi Andre, > > > >> The resulting object file is different (8 byte larger, > >> even), so it's hard to prove > > > > I'm no stranger to reading ob

Re: [PATCH v2 1/5] sunxi: psci: clean away preprocessor macros

2023-08-18 Thread Sam Edwards
On 8/18/23 10:40, Sam Edwards wrote: On 8/18/23 07:11, Andre Przywara wrote: Hi Andre, The resulting object file is different (8 byte larger, even), so it's hard to prove I'm no stranger to reading object code. Since the output should be identical in principle, I'll spend a little bit of ti

Re: [PATCH v2 1/5] sunxi: psci: clean away preprocessor macros

2023-08-18 Thread Sam Edwards
On 8/18/23 07:11, Andre Przywara wrote: Hi Andre, The resulting object file is different (8 byte larger, even), so it's hard to prove I'm no stranger to reading object code. Since the output should be identical in principle, I'll spend a little bit of time today seeing if I can identify wha

Re: [PATCH v2 1/5] sunxi: psci: clean away preprocessor macros

2023-08-18 Thread Andre Przywara
On Wed, 16 Aug 2023 10:34:16 -0700 Sam Edwards wrote: Hi Sam, thanks for the update. > This patch restructures psci.c to get away from the "many different > function definitions switched by #ifdef" paradigm to the preferred style > of having a single function definition with `if (IS_ENABLED(...

[PATCH v2 1/5] sunxi: psci: clean away preprocessor macros

2023-08-16 Thread Sam Edwards
This patch restructures psci.c to get away from the "many different function definitions switched by #ifdef" paradigm to the preferred style of having a single function definition with `if (IS_ENABLED(...))` to make the optimizer include only the appropriate function bodies instead. There are no f