[PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

2021-03-02 Thread Kory Maincent
Add the extension_board_scan specific function to scan the information of the EEPROM on one-wire and fill the extension struct. Signed-off-by: Kory Maincent --- arch/arm/mach-sunxi/Kconfig | 2 + board/sunxi/Makefile| 1 + board/sunxi/chip.c | 104 +++

Re: [PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

2021-03-02 Thread Maxime Ripard
Hi, On Tue, Mar 02, 2021 at 10:58:11AM +0100, Kory Maincent wrote: > Add the extension_board_scan specific function to scan the information > of the EEPROM on one-wire and fill the extension struct. > > Signed-off-by: Kory Maincent > --- > arch/arm/mach-sunxi/Kconfig | 2 + > board/sunxi/Make

Re: [PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

2021-03-02 Thread Köry Maincent
Hello Maxime, Thanks for your review. On Tue, 2 Mar 2021 17:05:38 +0100 Maxime Ripard wrote: > The split of that patch and the previous one is weird: you're adding a > Kconfig symbol doing close to nothing in patch 9, and you add the logic > behind it here > > It would be more natural to have

Re: [PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

2021-03-02 Thread Maxime Ripard
On Tue, Mar 02, 2021 at 05:14:44PM +0100, Köry Maincent wrote: > Hello Maxime, > > Thanks for your review. > > On Tue, 2 Mar 2021 17:05:38 +0100 > Maxime Ripard wrote: > > > The split of that patch and the previous one is weird: you're adding a > > Kconfig symbol doing close to nothing in patc