Re: [PATCH v2 13/20] rockchip: migrate hardware.h inclusion into appropriate files

2024-02-09 Thread Johan Jonker
On 2/9/24 10:50, Quentin Schulz wrote: > From: Quentin Schulz > > hardware.h is only defining macros which are "wrappers" around writel(). > > writel() is however not available in hardware.h, needs to be > included. This means in order to use the wrappers in hardware.h, one > also needs to

Re: [PATCH v2 13/20] rockchip: migrate hardware.h inclusion into appropriate files

2024-02-09 Thread Quentin Schulz
Hi Johan, On 2/9/24 14:07, Johan Jonker wrote: [...] From codingstyle.rst: You should follow this ordering in U-Boot. The common.h header (which is going away at some point) should always be first, followed by other headers in order, then headers with directories, then local files. Within

[PATCH v2 13/20] rockchip: migrate hardware.h inclusion into appropriate files

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz hardware.h is only defining macros which are "wrappers" around writel(). writel() is however not available in hardware.h, needs to be included. This means in order to use the wrappers in hardware.h, one also needs to include the header. However, this cannot be done