Re: [PATCH v2 15/18] spl: Commit MTRRs only in board_init_f_r()

2023-05-04 Thread Simon Glass
Hi Bin, On Thu, 4 May 2023 at 08:22, Bin Meng wrote: > > Hi Simon, > > On Tue, Apr 18, 2023 at 11:31 PM Simon Glass wrote: > > > > We don't need to commit the SPI-flash MTRR change immediately, since it is > > now done in the board_init_f_r(). Also this causes chromebook_link64 to > > hang. > >

Re: [PATCH v2 15/18] spl: Commit MTRRs only in board_init_f_r()

2023-05-04 Thread Bin Meng
Hi Simon, On Tue, Apr 18, 2023 at 11:31 PM Simon Glass wrote: > > We don't need to commit the SPI-flash MTRR change immediately, since it is > now done in the board_init_f_r(). Also this causes chromebook_link64 to > hang. Could you add more details as to why this causes chromebook_link64 to han

[PATCH v2 15/18] spl: Commit MTRRs only in board_init_f_r()

2023-04-18 Thread Simon Glass
We don't need to commit the SPI-flash MTRR change immediately, since it is now done in the board_init_f_r(). Also this causes chromebook_link64 to hang. Drop the extra mtrr_commit() in the SPL implementation. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/spl.c | 1 - 1 fil