Re: [PATCH v2 2/2] nvmxip: add sandbox support

2023-08-16 Thread Marek Vasut
On 8/16/23 18:39, Abdellatif El Khlifi wrote: Hi Marek, Hi, Please kindly find my comments below. arch/sandbox/dts/sandbox.dts | 14 ++ Please separate DT change configs/sandbox_defconfig | 4 ++-- Config change too, separate patch that goes last. This c

Re: [PATCH v2 2/2] nvmxip: add sandbox support

2023-08-16 Thread Abdellatif El Khlifi
Hi Marek, Please kindly find my comments below. > > arch/sandbox/dts/sandbox.dts | 14 ++ > > Please separate DT change > > > configs/sandbox_defconfig | 4 ++-- > > Config change too, separate patch that goes last. This commit is doing 1 thing: adding 32-bit sandb

Re: [PATCH v2 2/2] nvmxip: add sandbox support

2023-08-16 Thread Marek Vasut
On 8/16/23 13:05, Abdellatif El Khlifi wrote: enable the 32-bit version of sandbox Initially NVMXIP came with sandbox64 support. Let's enable sandbox support as well. Signed-off-by: Abdellatif El Khlifi Cc: Tom Rini Cc: Simon Glass Cc: Marek Vasut --- Changelog: === v2: * sp

[PATCH v2 2/2] nvmxip: add sandbox support

2023-08-16 Thread Abdellatif El Khlifi
enable the 32-bit version of sandbox Initially NVMXIP came with sandbox64 support. Let's enable sandbox support as well. Signed-off-by: Abdellatif El Khlifi Cc: Tom Rini Cc: Simon Glass Cc: Marek Vasut --- Changelog: === v2: * split into 2 commits: one for sandbox 32-bit suppo