Re: [PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Tom Rini
On Fri, Feb 09, 2024 at 07:37:28PM +0100, Heinrich Schuchardt wrote: > On 2/9/24 19:12, Tom Rini wrote: > > On Fri, Feb 09, 2024 at 04:51:15PM +0100, Heinrich Schuchardt wrote: > > > > > We should not use the reserved value 0x00 for the wake up type but > > > use 0x02 (Unknown). > > > > > >

Re: [PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Heinrich Schuchardt
On 2/9/24 19:12, Tom Rini wrote: On Fri, Feb 09, 2024 at 04:51:15PM +0100, Heinrich Schuchardt wrote: We should not use the reserved value 0x00 for the wake up type but use 0x02 (Unknown). Signed-off-by: Heinrich Schuchardt [snip] @@ -108,6 +108,16 @@ struct __packed smbios_type0 {

Re: [PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Tom Rini
On Fri, Feb 09, 2024 at 04:51:15PM +0100, Heinrich Schuchardt wrote: > We should not use the reserved value 0x00 for the wake up type but > use 0x02 (Unknown). > > Signed-off-by: Heinrich Schuchardt [snip] > @@ -108,6 +108,16 @@ struct __packed smbios_type0 { > char

[PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Heinrich Schuchardt
We should not use the reserved value 0x00 for the wake up type but use 0x02 (Unknown). Signed-off-by: Heinrich Schuchardt --- v2: use wake-up type 'Unknown' as our default add more SMBIOS wake-up type constants --- include/smbios.h | 10 ++ lib/smbios.c | 1 + 2