Re: [PATCH v2 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling

2022-01-28 Thread Alper Nebi Yasak
On 21/01/2022 18:20, Simon Glass wrote: > On Tue, 11 Jan 2022 at 06:40, Alper Nebi Yasak > wrote: >> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c >> index 278473899c7c..f0d7ba4774d6 100644 >> --- a/drivers/mmc/rockchip_sdhci.c >> +++ b/drivers/mmc/rockchip_sdhci.c >> @

Re: [PATCH v2 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling

2022-01-21 Thread Simon Glass
Hi Alper, On Tue, 11 Jan 2022 at 06:40, Alper Nebi Yasak wrote: > > The Rockchip RK3399 eMMC PHY has to be power-cycled while changing its > clock speed to some higher speeds. This is dependent on the desired > SDHCI clock speed, and it looks like the PHY should be powered off while > setting the

[PATCH v2 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling

2022-01-11 Thread Alper Nebi Yasak
The Rockchip RK3399 eMMC PHY has to be power-cycled while changing its clock speed to some higher speeds. This is dependent on the desired SDHCI clock speed, and it looks like the PHY should be powered off while setting the SDHCI clock in these cases. Commit ac804143cfd1 ("mmc: rockchip_sdhci: add