Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-12 Thread Alain Volmat
Hi Jorge On Sun, Sep 11, 2022 at 08:57:17PM +0200, Jorge Ramirez-Ortiz, Foundries wrote: > On 09/09/22, Alain Volmat wrote: > > Hi Patrick > > > > On Fri, Sep 09, 2022 at 02:53:23PM +0200, Patrick DELAUNAY wrote: > > > Hi Alain > > > > > > On 9/8/22 12:59, Alain Volmat wrote: > > > > Current fun

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-11 Thread Jorge Ramirez-Ortiz, Foundries
On 09/09/22, Alain Volmat wrote: > Hi Patrick > > On Fri, Sep 09, 2022 at 02:53:23PM +0200, Patrick DELAUNAY wrote: > > Hi Alain > > > > On 9/8/22 12:59, Alain Volmat wrote: > > > Current function stm32_i2c_message_xfer is sending a STOP > > > whatever the result of the transaction is. This can

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-09 Thread Alain Volmat
Hi Patrick On Fri, Sep 09, 2022 at 02:53:23PM +0200, Patrick DELAUNAY wrote: > Hi Alain > > On 9/8/22 12:59, Alain Volmat wrote: > > Current function stm32_i2c_message_xfer is sending a STOP > > whatever the result of the transaction is. This can cause issues > > such as making the bus busy sinc

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-09 Thread Patrick DELAUNAY
Hi Alain On 9/8/22 12:59, Alain Volmat wrote: Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is. This can cause issues such as making the bus busy since the controller itself is already sending automatically a STOP when a NACK is generated. Thi

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-09 Thread Patrick DELAUNAY
Hi, On 9/9/22 10:43, Heiko Schocher wrote: Hello Jorge, On 09.09.22 10:30, Jorge Ramirez-Ortiz, Foundries wrote: On 08/09/22, Patrick DELAUNAY wrote: Hi, On 9/8/22 12:59, Alain Volmat wrote: Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is.

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-09 Thread Heiko Schocher
Hello Jorge, On 09.09.22 10:30, Jorge Ramirez-Ortiz, Foundries wrote: > On 08/09/22, Patrick DELAUNAY wrote: >> Hi, >> >> On 9/8/22 12:59, Alain Volmat wrote: >>> Current function stm32_i2c_message_xfer is sending a STOP >>> whatever the result of the transaction is. This can cause issues >>> suc

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-09 Thread Jorge Ramirez-Ortiz, Foundries
On 08/09/22, Patrick DELAUNAY wrote: > Hi, > > On 9/8/22 12:59, Alain Volmat wrote: > > Current function stm32_i2c_message_xfer is sending a STOP > > whatever the result of the transaction is. This can cause issues > > such as making the bus busy since the controller itself is already > > sending

[PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-08 Thread Alain Volmat
Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is. This can cause issues such as making the bus busy since the controller itself is already sending automatically a STOP when a NACK is generated. This can be especially seen when the processing get

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-08 Thread Patrick DELAUNAY
Hi, On 9/8/22 12:59, Alain Volmat wrote: Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is. This can cause issues such as making the bus busy since the controller itself is already sending automatically a STOP when a NACK is generated. This can