Re: [PATCH v2 3/6] cmd: fru: fix a sandbox segfault issue

2022-08-16 Thread Jae Hyun Yoo
Hi Simon, On 8/16/2022 1:42 PM, Simon Glass wrote: [...] Reviewed-by: Simon Glass Thanks for your review! [...] int fru_display(int verbose); -int fru_capture(unsigned long addr); -int fru_generate(unsigned long addr, int argc, char *const argv[]); +int fru_capture(const void

Re: [PATCH v2 3/6] cmd: fru: fix a sandbox segfault issue

2022-08-16 Thread Simon Glass
Hi Jae, On Mon, 15 Aug 2022 at 16:58, Jae Hyun Yoo wrote: > > This command doesn't work with sandbox because direct memory access > causes a segfault error. Fix it up using map_sysmem(). > > Signed-off-by: Jae Hyun Yoo > --- > Changes from v1: > * Newly added in v2. > >

[PATCH v2 3/6] cmd: fru: fix a sandbox segfault issue

2022-08-15 Thread Jae Hyun Yoo
This command doesn't work with sandbox because direct memory access causes a segfault error. Fix it up using map_sysmem(). Signed-off-by: Jae Hyun Yoo --- Changes from v1: * Newly added in v2. board/xilinx/common/board.c | 2 +- cmd/fru.c | 20 +---