Re: [PATCH v2 5/5] xen: Code style conformity

2020-08-25 Thread Tom Rini
On Fri, Aug 21, 2020 at 12:10:04PM +0300, Anastasiia Lukianenko wrote: > From: Anastasiia Lukianenko > > Cleaning up the following: > > ERROR: do not use assignment in if condition > #281: FILE: drivers/xen/pvblock.c:260: > + if ((err = xenbus_switch_state(XBT_NIL, nodename, >

Re: [PATCH v2 5/5] xen: Code style conformity

2020-08-22 Thread Simon Glass
On Fri, 21 Aug 2020 at 03:10, Anastasiia Lukianenko wrote: > > From: Anastasiia Lukianenko > > Cleaning up the following: > > ERROR: do not use assignment in if condition > #281: FILE: drivers/xen/pvblock.c:260: > + if ((err = xenbus_switch_state(XBT_NIL, nodename, >

[PATCH v2 5/5] xen: Code style conformity

2020-08-21 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Cleaning up the following: ERROR: do not use assignment in if condition #281: FILE: drivers/xen/pvblock.c:260: + if ((err = xenbus_switch_state(XBT_NIL, nodename, CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "err" #52: FILE: