[PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-03-15 Thread Alexandru Gagniuc
This test verifies that ECDSA_UCLASS is implemented, and that ecdsa_verify() works as expected. The definition of "expected" is "does not find a device, and returns -ENODEV". The lack of a hardware-independent ECDSA implementation prevents us from having one in the sandbox, for now. Signed-off-by

Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-03-29 Thread Simon Glass
Hi Alexandru, On Tue, 16 Mar 2021 at 13:24, Alexandru Gagniuc wrote: > > This test verifies that ECDSA_UCLASS is implemented, and that > ecdsa_verify() works as expected. The definition of "expected" is > "does not find a device, and returns -ENODEV". > > The lack of a hardware-independent ECDSA

Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-03-29 Thread Alex G.
+ Tim On 3/29/21 2:43 AM, Simon Glass wrote: Hi Alexandru, On Tue, 16 Mar 2021 at 13:24, Alexandru Gagniuc wrote: This test verifies that ECDSA_UCLASS is implemented, and that ecdsa_verify() works as expected. The definition of "expected" is "does not find a device, and returns -ENODEV". Th

RE: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-03-30 Thread Tim Romanski
G. Sent: March 29, 2021 2:43 PM To: Simon Glass Cc: U-Boot Mailing List ; Tom Rini ; Tim Romanski Subject: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support + Tim On 3/29/21 2:43 AM, Simon Glass wrote: > Hi Alexandru, > > On Tue, 16 Mar 2021 at 13:24, A

Re: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-04-07 Thread Tim Romanski
C'd my @linux.microsoft.com email, I prefer to use that one from now on. All the best, Tim -Original Message- From: Alex G. Sent: March 29, 2021 2:43 PM To: Simon Glass Cc: U-Boot Mailing List ; Tom Rini ; Tim Romanski Subject: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for

Re: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-04-07 Thread Alex G.
On 4/7/21 12:29 PM, Tim Romanski wrote: Question for Alex, I see your repo has a few branches related to ECDSA (patch-ecdsa-v[1-5], patch-mkimage-keyfile-v{1,2}). You sent me a link to 'patch-ecdsa-v1' in a previous email, is that the one that's being upstreamed? Should I be working off a diff

Re: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-04-08 Thread Alex G.
On 4/8/21 11:56 AM, Tim Romanski wrote: Ok, will do. I'm writing the verification code, I noticed you're passing the public key into the fdt using fdt_add_bignum, which converts the x and y values into big endian integer arrays. Do you have a method to read these values from the fdt and convert

Re: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-04-08 Thread Tim Romanski
Ok, will do. I'm writing the verification code, I noticed you're passing the public key into the fdt using fdt_add_bignum, which converts the x and y values into big endian integer arrays. Do you have a method to read these values from the fdt and convert them back into bignums, or is that TODO

Re: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-04-23 Thread Tim Romanski
Update on ECDSA verification progress, I've forked Alex's repo and have included my changes in the 'ecdsa-vrf-1' branch [1]. This includes the isolated OpenSSL code for verification, and I split up the lib/ecdsa/ecdsa-libcrypto.c file into lib/ecdsa/ecdsa-sign.c and lib/ecdsa/ecdsa-verify.c. I'

Re: [EXTERNAL] Re: [PATCH v2 6/6] test: dm: Add test for ECDSA UCLASS support

2021-04-24 Thread Tom Rini
On Fri, Apr 23, 2021 at 01:03:25PM -0400, Tim Romanski wrote: > Update on ECDSA verification progress, I've forked Alex's repo and have > included my changes in the 'ecdsa-vrf-1' branch [1]. This includes the > isolated OpenSSL code for verification, and I split up the > lib/ecdsa/ecdsa-libcrypto.