Re: [PATCH v3] tools: copyfile: use 64k instead of 512 buffer

2024-04-04 Thread Dragan Simic
Hello Ahelenia, Just checking, have you forgotten about this patch? On 2024-03-21 21:50, Dragan Simic wrote: On 2024-03-21 21:37, Ahelenia Ziemiańska wrote: This is a trivial but significant optimization: mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (and

[PATCH v3] tools: copyfile: use 64k instead of 512 buffer

2024-03-21 Thread Ahelenia Ziemiańska
This is a trivial but significant optimization: mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (and 419 writes (of which 386 64k)). sendfile is much more appropriate for this and is done in one syscall, but doesn't bring any significant speedups over 64k r/w

Re: [PATCH v3] tools: copyfile: use 64k instead of 512 buffer

2024-03-21 Thread Dragan Simic
On 2024-03-21 21:37, Ahelenia Ziemiańska wrote: This is a trivial but significant optimization: mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (and 419 writes (of which 386 64k)). sendfile is much more appropriate for this and is done in one syscall, but