Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-21 Thread Ilias Apalodimas
On Thu, 16 May 2024 at 13:40, Miquel Raynal wrote: > > > > > > Signed-off-by: Jorge Ramirez-Ortiz > > > > > > You cannot send your SoB like this. SoB means you are carrying some > > > code which complies with the license, etc. > > > > > > Either you were part of the original writing and want to

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-21 Thread Ilias Apalodimas
On Thu, 16 May 2024 at 02:21, Tim Harvey wrote: > > Instead of displaying what looks like an error message if a > gpio-reset dt prop is missing for a TPM display a warning that > having a gpio reset on a TPM should not be used for a secure production > device. > > TCG TIS spec [1] says: > "The

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Miquel Raynal
> > > Signed-off-by: Jorge Ramirez-Ortiz > > > > You cannot send your SoB like this. SoB means you are carrying some > > code which complies with the license, etc. > > > > Either you were part of the original writing and want to be credited > > for that (you can be the author and first SoB,

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Jorge Ramirez-Ortiz, Foundries
On 16/05/24 11:34:14, Miquel Raynal wrote: > Hi Jorge, > > ... > > > > > - board with no reset gpio > > > > u-boot=> tpm init && tpm info > > > > tpm@1 v2.0: VendorID 0x1114, DeviceID 0x3205, RevisionID 0x01 [open] > > > > - board with a reset gpio > > > > u-boot=> tpm init && tpm info > > > >

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Miquel Raynal
Hi Jorge, ... > > > - board with no reset gpio > > > u-boot=> tpm init && tpm info > > > tpm@1 v2.0: VendorID 0x1114, DeviceID 0x3205, RevisionID 0x01 [open] > > > - board with a reset gpio > > > u-boot=> tpm init && tpm info > > > tpm@1: TPM gpio reset should not be used on secure production

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Jorge Ramirez-Ortiz, Foundries
On 16/05/24 09:09:50, Miquel Raynal wrote: > Hi Tim, > > thar...@gateworks.com wrote on Wed, 15 May 2024 16:21:38 -0700: > > > Instead of displaying what looks like an error message if a > > gpio-reset dt prop is missing for a TPM display a warning that > > having a gpio reset on a TPM should

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Miquel Raynal
Hi Tim, thar...@gateworks.com wrote on Wed, 15 May 2024 16:21:38 -0700: > Instead of displaying what looks like an error message if a > gpio-reset dt prop is missing for a TPM display a warning that > having a gpio reset on a TPM should not be used for a secure production > device. > > TCG TIS

[PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-15 Thread Tim Harvey
Instead of displaying what looks like an error message if a gpio-reset dt prop is missing for a TPM display a warning that having a gpio reset on a TPM should not be used for a secure production device. TCG TIS spec [1] says: "The TPM_Init (LRESET#/SPI_RST#) signal MUST be connected to the