Re: [PATCH v3 04/12] reset: Add generic reset driver

On 2/4/20 6:06 AM, Bin Meng wrote: > Hi Sean, > > On Mon, Feb 3, 2020 at 4:01 AM Sean Anderson wrote: >> +Required properties: >> +- compatible: should contain "syscon-reset" > > Shouldn't we follow the same generic "syscon-reboot" device bindings > defined in the Linux kernel? > See

Re: [PATCH v3 04/12] reset: Add generic reset driver

Hi Sean, On Mon, Feb 3, 2020 at 4:01 AM Sean Anderson wrote: > > This patch adds a generic reset driver. It is designed to be useful when one > has > a register in a regmap which contains bits that reset other devices. I thought > this seemed like a very generic use, so here is a generic

Re: [PATCH v3 04/12] reset: Add generic reset driver

> Is there a sandbox test for this driver somewhere in your series? There is not. Presumably if such a test were to exist, it would try asserting different resets, and then check to see if the associated register got changed. However, I am confused as to where such a test would be located. There

Re: [PATCH v3 04/12] reset: Add generic reset driver

HI Sean, On Sun, 2 Feb 2020 at 13:01, Sean Anderson wrote: > > This patch adds a generic reset driver. It is designed to be useful when one > has > a register in a regmap which contains bits that reset other devices. I thought > this seemed like a very generic use, so here is a generic driver.

[PATCH v3 04/12] reset: Add generic reset driver

This patch adds a generic reset driver. It is designed to be useful when one has a register in a regmap which contains bits that reset other devices. I thought this seemed like a very generic use, so here is a generic driver. The overall structure has been modeled on the syscon-reboot driver.