Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-03-03 Thread Harry Waschkeit
On 03.03.21 00:06, Sean Anderson wrote: On 3/2/21 1:09 PM, Harry Waschkeit wrote: Hello Sean, On 02.03.21 00:10, Sean Anderson wrote: On 3/1/21 11:39 AM, Harry Waschkeit wrote: Hi again, gentle ping for that patch, also in view of subsequently sent patch ...   https://lists.denx.de/piperma

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-03-02 Thread Sean Anderson
On 3/2/21 1:09 PM, Harry Waschkeit wrote: Hello Sean, On 02.03.21 00:10, Sean Anderson wrote: On 3/1/21 11:39 AM, Harry Waschkeit wrote: Hi again, gentle ping for that patch, also in view of subsequently sent patch ... https://lists.denx.de/pipermail/u-boot/2021-February/439797.html ...

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-03-02 Thread Harry Waschkeit
Hello Sean, On 02.03.21 00:10, Sean Anderson wrote: On 3/1/21 11:39 AM, Harry Waschkeit wrote: Hi again, gentle ping for that patch, also in view of subsequently sent patch ...   https://lists.denx.de/pipermail/u-boot/2021-February/439797.html ... which saw a competing patch by Patrick Dela

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-03-01 Thread Sean Anderson
On 3/1/21 11:39 AM, Harry Waschkeit wrote: Hi again, gentle ping for that patch, also in view of subsequently sent patch ... https://lists.denx.de/pipermail/u-boot/2021-February/439797.html ... which saw a competing patch by Patrick Delaunay a week later: https://lists.denx.de/pipermail/

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-03-01 Thread Harry Waschkeit
Hi again, gentle ping for that patch, also in view of subsequently sent patch ... https://lists.denx.de/pipermail/u-boot/2021-February/439797.html ... which saw a competing patch by Patrick Delaunay a week later: https://lists.denx.de/pipermail/u-boot/2021-February/440769.html However, the

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-02-02 Thread Stefan Roese
On 02.02.21 18:09, Harry Waschkeit wrote: On 02.02.21 15:54, Stefan Roese wrote: On 02.02.21 15:43, Harry Waschkeit wrote:  On 02.02.21 10:30, Stefan Roese wrote: On 02.02.21 09:21, Harry Waschkeit wrote: Instead of implementing redundant environments in two very similar functions env_sf_sa

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-02-02 Thread Harry Waschkeit
On 02.02.21 15:54, Stefan Roese wrote: On 02.02.21 15:43, Harry Waschkeit wrote:  On 02.02.21 10:30, Stefan Roese wrote: On 02.02.21 09:21, Harry Waschkeit wrote: Instead of implementing redundant environments in two very similar functions env_sf_save(), handle redundancy in one function, pl

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-02-02 Thread Stefan Roese
On 02.02.21 15:43, Harry Waschkeit wrote:  On 02.02.21 10:30, Stefan Roese wrote: On 02.02.21 09:21, Harry Waschkeit wrote: Instead of implementing redundant environments in two very similar functions env_sf_save(), handle redundancy in one function, placing the few differences in appropriate

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-02-02 Thread Harry Waschkeit
 On 02.02.21 10:30, Stefan Roese wrote: On 02.02.21 09:21, Harry Waschkeit wrote: Instead of implementing redundant environments in two very similar functions env_sf_save(), handle redundancy in one function, placing the few differences in appropriate pre-compiler sections depending on config

Re: [PATCH v3 1/1] env: sf: single function env_sf_save()

2021-02-02 Thread Stefan Roese
On 02.02.21 09:21, Harry Waschkeit wrote: Instead of implementing redundant environments in two very similar functions env_sf_save(), handle redundancy in one function, placing the few differences in appropriate pre-compiler sections depending on config option CONFIG_ENV_OFFSET_REDUND. Addition

[PATCH v3 1/1] env: sf: single function env_sf_save()

2021-02-02 Thread Harry Waschkeit
Instead of implementing redundant environments in two very similar functions env_sf_save(), handle redundancy in one function, placing the few differences in appropriate pre-compiler sections depending on config option CONFIG_ENV_OFFSET_REDUND. Additionally, several checkpatch complaints were add