Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-16 Thread Philip Oberfichtner
Just for the record: I solved the problem using ./tools/moveconfig.py -i CONFIG_SYS_L2_PL310 Patch V4 coming soon. On Thu, 2022-08-11 at 12:17 +0200, Philip Oberfichtner wrote: > Hi, > > following the whole discussion I figured using 'select SYS_l2_PL310 > if > !SYS_L2CACHE_OFF' is the

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-12 Thread Soeren Moch
On 09.08.22 12:07, Philip Oberfichtner wrote: This converts CONFIG_SYS_L2_PL310 to Kconfig. Signed-off-by: Philip Oberfichtner We used common includes before to select L2_PL31, e.g. for tbs2910 (and many more similar boards) we had mx6_common.h . Now with this conversion lots of individual

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-11 Thread Philip Oberfichtner
Hi, following the whole discussion I figured using 'select SYS_l2_PL310 if !SYS_L2CACHE_OFF' is the preferred solution. Now the thing is, if I'd put this line under the ARCH_XXX Kconfig entries, I would change behavior for many boards. Take, for example, ARCH_MVEBU: grep -lr ARCH_MVEBU configs

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Marek Vasut
On 8/9/22 18:36, Tom Rini wrote: [...] It's tricky to say when to "select" or just "default y if .." or "imply" a given option. It's not only a matter of "can you disable X and the system is functional" but "would you normally want to". There are certainly system bring-up cases and similar

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Phil Sutter
On Tue, Aug 09, 2022 at 01:21:51PM +0200, Pali Rohár wrote: > On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: > > On 8/9/22 12:58, Pali Rohár wrote: > > > On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: > > > > This converts CONFIG_SYS_L2_PL310 to Kconfig. > > > ... > > > >

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Tom Rini
On Tue, Aug 09, 2022 at 06:03:15PM +0200, Marek Vasut wrote: > On 8/9/22 15:46, Tom Rini wrote: > > On Tue, Aug 09, 2022 at 01:32:24PM +0200, Pali Rohár wrote: > > > On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: > > > > On 8/9/22 13:21, Pali Rohár wrote: > > > > > > > > (reducing the CC

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Marek Vasut
On 8/9/22 15:46, Tom Rini wrote: On Tue, Aug 09, 2022 at 01:32:24PM +0200, Pali Rohár wrote: On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: On 8/9/22 13:21, Pali Rohár wrote: (reducing the CC list) On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: On 8/9/22 12:58, Pali Rohár

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Tom Rini
On Tue, Aug 09, 2022 at 01:32:24PM +0200, Pali Rohár wrote: > On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: > > On 8/9/22 13:21, Pali Rohár wrote: > > > > (reducing the CC list) > > > > > On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: > > > > On 8/9/22 12:58, Pali Rohár wrote: > >

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Marek Behún
On Tue, 9 Aug 2022 15:16:35 +0200 Marek Behún wrote: > > I agree -- I think your proposal to make this non-user-configurable is > > changing the behavior, see: > > > > Before -- you could comment the entry in include/configs/board.h out to > > deselect an option. > > After -- you can flip

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Marek Behún
On Tue, 9 Aug 2022 13:38:32 +0200 Marek Vasut wrote: > On 8/9/22 13:32, Pali Rohár wrote: > > On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: > >> On 8/9/22 13:21, Pali Rohár wrote: > >> > >> (reducing the CC list) > >> > >>> On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: >

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Pali Rohár
On Tuesday 09 August 2022 13:38:32 Marek Vasut wrote: > On 8/9/22 13:32, Pali Rohár wrote: > > On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: > > > On 8/9/22 13:21, Pali Rohár wrote: > > > > > > (reducing the CC list) > > > > > > > On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: > >

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Pali Rohár
On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: > On 8/9/22 12:58, Pali Rohár wrote: > > On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: > > > This converts CONFIG_SYS_L2_PL310 to Kconfig. > > ... > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > index

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Marek Vasut
On 8/9/22 12:58, Pali Rohár wrote: On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: This converts CONFIG_SYS_L2_PL310 to Kconfig. ... diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 949ebb46ba..dde06bdd96 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -488,6

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Pali Rohár
On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: > This converts CONFIG_SYS_L2_PL310 to Kconfig. ... > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 949ebb46ba..dde06bdd96 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -488,6 +488,10 @@ config

[PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Philip Oberfichtner
This converts CONFIG_SYS_L2_PL310 to Kconfig. Signed-off-by: Philip Oberfichtner --- Changes in v3: new README| 2 -- arch/arm/Kconfig | 4 arch/arm/mach-mvebu/include/mach/config.h | 2 -- configs/am43xx_evm_defconfig

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Marek Vasut
On 8/9/22 13:32, Pali Rohár wrote: On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: On 8/9/22 13:21, Pali Rohár wrote: (reducing the CC list) On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: On 8/9/22 12:58, Pali Rohár wrote: On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Pali Rohár
On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: > On 8/9/22 13:21, Pali Rohár wrote: > > (reducing the CC list) > > > On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: > > > On 8/9/22 12:58, Pali Rohár wrote: > > > > On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: > > > >

Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig

2022-08-09 Thread Marek Vasut
On 8/9/22 13:21, Pali Rohár wrote: (reducing the CC list) On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: On 8/9/22 12:58, Pali Rohár wrote: On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: This converts CONFIG_SYS_L2_PL310 to Kconfig. ... diff --git a/arch/arm/Kconfig