Re: [PATCH v3 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-04-03 Thread Eugen Hristev
On 4/2/23 14:04, Jonas Karlman wrote: Hi Eugen, On 2023-03-31 11:40, Eugen Hristev wrote: Add initial support for the rk3588 PHY variant. The driver now looks for phy-supply and enables/disables the vbus accordingly. Maybe this should be added to core phy uclass to closer match linux? Look

Re: [PATCH v3 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-04-02 Thread Jonas Karlman
Hi Eugen, On 2023-03-31 11:40, Eugen Hristev wrote: > Add initial support for the rk3588 PHY variant. > The driver now looks for phy-supply and enables/disables the vbus > accordingly. Maybe this should be added to core phy uclass to closer match linux? Look like e.g. meson phy drivers also

[PATCH v3 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-31 Thread Eugen Hristev
Add initial support for the rk3588 PHY variant. The driver now looks for phy-supply and enables/disables the vbus accordingly. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first check for reg == 0. Co-developed-by: Frank